chore: param store doesn't use gas kv (#202)

* chore: param store doesn't use gas kv

* chore: apply comment

* chore: fix lint error

Author: Woosang Son

store/types/gas_test.go

@@ -88,17 +88,3 @@ func TestAddUint64Overflow(t *testing.T) {
 		)
 	}
 }
-
-func TestTransientGasConfig(t *testing.T) {
-	t.Parallel()
-	config := TransientGasConfig()
-	require.Equal(t, config, GasConfig{
-		HasCost:          1000,
-		DeleteCost:       1000,
-		ReadCostFlat:     1000,
-		ReadCostPerByte:  3,
-		WriteCostFlat:    2000,
-		WriteCostPerByte: 30,
-		IterNextCostFlat: 30,
-	})
-}

x/params/keeper/keeper_test.go

@@ -189,12 +189,10 @@ func TestSubspace(t *testing.T) {
 	store := prefix.NewStore(ctx.KVStore(key), []byte("test/"))
 	space := keeper.Subspace("test").WithKeyTable(table)
 
-	// Test space.Set, space.Modified
+	// Test space.Set
 	for i, kv := range kvs {
 		i, kv := i, kv
-		require.False(t, space.Modified(ctx, []byte(kv.key)), "space.Modified returns true before setting, tc #%d", i)
 		require.NotPanics(t, func() { space.Set(ctx, []byte(kv.key), kv.param) }, "space.Set panics, tc #%d", i)
-		require.True(t, space.Modified(ctx, []byte(kv.key)), "space.Modified returns false after setting, tc #%d", i)
 	}
 
 	// Test space.Get, space.GetIfExists

x/params/types/subspace.go

@@ -75,15 +75,7 @@ func (s *Subspace) kvStore(ctx sdk.Context) sdk.KVStore {
 	// this function can be called concurrently so we should not call append on s.name directly
 	name := make([]byte, len(s.name))
 	copy(name, s.name)
-	return prefix.NewStore(ctx.KVStore(s.key), append(name, '/'))
-}
-
-// Returns a transient store for modification
-func (s *Subspace) transientStore(ctx sdk.Context) sdk.KVStore {
-	// this function can be called concurrently so we should not call append on s.name directly
-	name := make([]byte, len(s.name))
-	copy(name, s.name)
-	return prefix.NewStore(ctx.TransientStore(s.tkey), append(name, '/'))
+	return prefix.NewStore(ctx.MultiStore().GetKVStore(s.key), append(name, '/'))
 }
 
 // Validate attempts to validate a parameter value by its key. If the key is not
@@ -156,13 +148,6 @@ func (s *Subspace) Has(ctx sdk.Context, key []byte) bool {
 	return store.Has(key)
 }
 
-// Modified returns true if the parameter key is set in the Subspace's transient
-// KVStore.
-func (s *Subspace) Modified(ctx sdk.Context, key []byte) bool {
-	tstore := s.transientStore(ctx)
-	return tstore.Has(key)
-}
-
 // checkType verifies that the provided key and value are comptable and registered.
 func (s *Subspace) checkType(key []byte, value interface{}) {
 	attr, ok := s.table.m[string(key)]
@@ -258,10 +243,6 @@ func (s *Subspace) Set(ctx sdk.Context, key []byte, value interface{}) {
 	}
 
 	store.Set(key, bz)
-
-	tstore := s.transientStore(ctx)
-	tstore.Set(key, []byte{})
-
 	s.cacheValue(key, value)
 }
 
@@ -348,11 +329,6 @@ func (ros ReadOnlySubspace) Has(ctx sdk.Context, key []byte) bool {
 	return ros.s.Has(ctx, key)
 }
 
-// Modified delegates a read-only Modified call to the Subspace.
-func (ros ReadOnlySubspace) Modified(ctx sdk.Context, key []byte) bool {
-	return ros.s.Modified(ctx, key)
-}
-
 // Name delegates a read-only Name call to the Subspace.
 func (ros ReadOnlySubspace) Name() string {
 	return ros.s.Name()

x/params/types/subspace_test.go

@@ -102,16 +102,6 @@ func (suite *SubspaceTestSuite) TestHas() {
 	suite.Require().True(suite.ss.Has(suite.ctx, keyUnbondingTime))
 }
 
-func (suite *SubspaceTestSuite) TestModified() {
-	t := time.Hour * 48
-
-	suite.Require().False(suite.ss.Modified(suite.ctx, keyUnbondingTime))
-	suite.Require().NotPanics(func() {
-		suite.ss.Set(suite.ctx, keyUnbondingTime, t)
-	})
-	suite.Require().True(suite.ss.Modified(suite.ctx, keyUnbondingTime))
-}
-
 func (suite *SubspaceTestSuite) TestUpdate() {
 	suite.Require().Panics(func() {
 		suite.ss.Update(suite.ctx, []byte("invalid_key"), nil) // nolint:errcheck