Skip to content

Commit 85695a4

Browse files
jaeseung-baejaeseung-bae
authored
feat(x/foundation): remove unnecessary gov-mint feature (#848)
* feat(x/foundation): remove gov-mint feature since the feature is unnecessary * feat(x/foundation): update changelog with pr number * refactor(x/foundation): make govMintKey deprecate * refactor(x/foundation): fix for lint ci of unused variable(which is deprecated)
1 parent 3bdcb6f commit 85695a4

35 files changed

+229
-1957
lines changed

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
3838
## [Unreleased](https://github.com/line/lbm-sdk/compare/v0.46.0...HEAD)
3939

4040
### Features
41+
* (x/foundation) [\#848](https://github.com/line/lbm-sdk/pull/848) remove `gov mint` for x/foundation proposal
4142

4243
### Improvements
4344
* (cosmovisor) [\#792](https://github.com/line/lbm-sdk/pull/792) Use upstream's cosmovisor

‎client/docs/statik/statik.go

+1-1
Large diffs are not rendered by default.

‎client/docs/swagger-ui/swagger.yaml

-217
Original file line numberDiff line numberDiff line change
@@ -34104,212 +34104,6 @@ paths:
3410434104
type: string
3410534105
tags:
3410634106
- Query
34107-
/lbm/foundation/v1/gov_mint:
34108-
get:
34109-
summary: GovMint queries the left count of gov mint.
34110-
operationId: GovMint
34111-
responses:
34112-
'200':
34113-
description: A successful response.
34114-
schema:
34115-
type: object
34116-
properties:
34117-
leftCount:
34118-
type: integer
34119-
format: int64
34120-
description: leftCount is the left count of GovMint.
34121-
description: QueryGovMintResponse is the Query/GovMint response type.
34122-
default:
34123-
description: An unexpected error response
34124-
schema:
34125-
type: object
34126-
properties:
34127-
error:
34128-
type: string
34129-
code:
34130-
type: integer
34131-
format: int32
34132-
message:
34133-
type: string
34134-
details:
34135-
type: array
34136-
items:
34137-
type: object
34138-
properties:
34139-
type_url:
34140-
type: string
34141-
description: >-
34142-
A URL/resource name that uniquely identifies the type of
34143-
the serialized
34144-
34145-
protocol buffer message. This string must contain at
34146-
least
34147-
34148-
one "/" character. The last segment of the URL's path
34149-
must represent
34150-
34151-
the fully qualified name of the type (as in
34152-
34153-
`path/google.protobuf.Duration`). The name should be in
34154-
a canonical form
34155-
34156-
(e.g., leading "." is not accepted).
34157-
34158-
34159-
In practice, teams usually precompile into the binary
34160-
all types that they
34161-
34162-
expect it to use in the context of Any. However, for
34163-
URLs which use the
34164-
34165-
scheme `http`, `https`, or no scheme, one can optionally
34166-
set up a type
34167-
34168-
server that maps type URLs to message definitions as
34169-
follows:
34170-
34171-
34172-
* If no scheme is provided, `https` is assumed.
34173-
34174-
* An HTTP GET on the URL must yield a
34175-
[google.protobuf.Type][]
34176-
value in binary format, or produce an error.
34177-
* Applications are allowed to cache lookup results based
34178-
on the
34179-
URL, or have them precompiled into a binary to avoid any
34180-
lookup. Therefore, binary compatibility needs to be preserved
34181-
on changes to types. (Use versioned type names to manage
34182-
breaking changes.)
34183-
34184-
Note: this functionality is not currently available in
34185-
the official
34186-
34187-
protobuf release, and it is not used for type URLs
34188-
beginning with
34189-
34190-
type.googleapis.com.
34191-
34192-
34193-
Schemes other than `http`, `https` (or the empty scheme)
34194-
might be
34195-
34196-
used with implementation specific semantics.
34197-
value:
34198-
type: string
34199-
format: byte
34200-
description: >-
34201-
Must be a valid serialized protocol buffer of the above
34202-
specified type.
34203-
description: >-
34204-
`Any` contains an arbitrary serialized protocol buffer
34205-
message along with a
34206-
34207-
URL that describes the type of the serialized message.
34208-
34209-
34210-
Protobuf library provides support to pack/unpack Any values
34211-
in the form
34212-
34213-
of utility functions or additional generated methods of the
34214-
Any type.
34215-
34216-
34217-
Example 1: Pack and unpack a message in C++.
34218-
34219-
Foo foo = ...;
34220-
Any any;
34221-
any.PackFrom(foo);
34222-
...
34223-
if (any.UnpackTo(&foo)) {
34224-
...
34225-
}
34226-
34227-
Example 2: Pack and unpack a message in Java.
34228-
34229-
Foo foo = ...;
34230-
Any any = Any.pack(foo);
34231-
...
34232-
if (any.is(Foo.class)) {
34233-
foo = any.unpack(Foo.class);
34234-
}
34235-
34236-
Example 3: Pack and unpack a message in Python.
34237-
34238-
foo = Foo(...)
34239-
any = Any()
34240-
any.Pack(foo)
34241-
...
34242-
if any.Is(Foo.DESCRIPTOR):
34243-
any.Unpack(foo)
34244-
...
34245-
34246-
Example 4: Pack and unpack a message in Go
34247-
34248-
foo := &pb.Foo{...}
34249-
any, err := ptypes.MarshalAny(foo)
34250-
...
34251-
foo := &pb.Foo{}
34252-
if err := ptypes.UnmarshalAny(any, foo); err != nil {
34253-
...
34254-
}
34255-
34256-
The pack methods provided by protobuf library will by
34257-
default use
34258-
34259-
'type.googleapis.com/full.type.name' as the type URL and the
34260-
unpack
34261-
34262-
methods only use the fully qualified type name after the
34263-
last '/'
34264-
34265-
in the type URL, for example "foo.bar.com/x/y.z" will yield
34266-
type
34267-
34268-
name "y.z".
34269-
34270-
34271-
34272-
JSON
34273-
34274-
====
34275-
34276-
The JSON representation of an `Any` value uses the regular
34277-
34278-
representation of the deserialized, embedded message, with
34279-
an
34280-
34281-
additional field `@type` which contains the type URL.
34282-
Example:
34283-
34284-
package google.profile;
34285-
message Person {
34286-
string first_name = 1;
34287-
string last_name = 2;
34288-
}
34289-
34290-
{
34291-
"@type": "type.googleapis.com/google.profile.Person",
34292-
"firstName": <string>,
34293-
"lastName": <string>
34294-
}
34295-
34296-
If the embedded message type is well-known and has a custom
34297-
JSON
34298-
34299-
representation, that representation will be embedded adding
34300-
a field
34301-
34302-
`value` which holds the custom JSON in addition to the
34303-
`@type`
34304-
34305-
field. Example (for message [google.protobuf.Duration][]):
34306-
34307-
{
34308-
"@type": "type.googleapis.com/google.protobuf.Duration",
34309-
"value": "1.212s"
34310-
}
34311-
tags:
34312-
- Query
3431334107
'/lbm/foundation/v1/grants/{grantee}/{msg_type_url}':
3431434108
get:
3431534109
summary: 'Returns list of authorizations, granted to the grantee.'
@@ -45080,9 +44874,6 @@ paths:
4508044874
format: byte
4508144875
tags:
4508244876
- Service
45083-
securityDefinitions:
45084-
kms:
45085-
type: basic
4508644877
definitions:
4508744878
cosmos.auth.v1beta1.Params:
4508844879
type: object
@@ -68475,14 +68266,6 @@ definitions:
6847568266
Must be a valid serialized protocol buffer of the above
6847668267
specified type.
6847768268
description: QueryFoundationInfoResponse is the Query/FoundationInfo response type.
68478-
lbm.foundation.v1.QueryGovMintResponse:
68479-
type: object
68480-
properties:
68481-
leftCount:
68482-
type: integer
68483-
format: int64
68484-
description: leftCount is the left count of GovMint.
68485-
description: QueryGovMintResponse is the Query/GovMint response type.
6848668269
lbm.foundation.v1.QueryGrantsResponse:
6848768270
type: object
6848868271
properties:

‎docs/core/proto-docs.md

-74
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,6 @@
11251125
- [lbm/foundation/v1/event.proto](#lbm/foundation/v1/event.proto)
11261126
- [EventExec](#lbm.foundation.v1.EventExec)
11271127
- [EventFundTreasury](#lbm.foundation.v1.EventFundTreasury)
1128-
- [EventGovMint](#lbm.foundation.v1.EventGovMint)
11291128
- [EventGrant](#lbm.foundation.v1.EventGrant)
11301129
- [EventLeaveFoundation](#lbm.foundation.v1.EventLeaveFoundation)
11311130
- [EventRevoke](#lbm.foundation.v1.EventRevoke)
@@ -1144,8 +1143,6 @@
11441143
- [lbm/foundation/v1/query.proto](#lbm/foundation/v1/query.proto)
11451144
- [QueryFoundationInfoRequest](#lbm.foundation.v1.QueryFoundationInfoRequest)
11461145
- [QueryFoundationInfoResponse](#lbm.foundation.v1.QueryFoundationInfoResponse)
1147-
- [QueryGovMintRequest](#lbm.foundation.v1.QueryGovMintRequest)
1148-
- [QueryGovMintResponse](#lbm.foundation.v1.QueryGovMintResponse)
11491146
- [QueryGrantsRequest](#lbm.foundation.v1.QueryGrantsRequest)
11501147
- [QueryGrantsResponse](#lbm.foundation.v1.QueryGrantsResponse)
11511148
- [QueryMemberRequest](#lbm.foundation.v1.QueryMemberRequest)
@@ -1174,8 +1171,6 @@
11741171
- [MsgExecResponse](#lbm.foundation.v1.MsgExecResponse)
11751172
- [MsgFundTreasury](#lbm.foundation.v1.MsgFundTreasury)
11761173
- [MsgFundTreasuryResponse](#lbm.foundation.v1.MsgFundTreasuryResponse)
1177-
- [MsgGovMint](#lbm.foundation.v1.MsgGovMint)
1178-
- [MsgGovMintResponse](#lbm.foundation.v1.MsgGovMintResponse)
11791174
- [MsgGrant](#lbm.foundation.v1.MsgGrant)
11801175
- [MsgGrantResponse](#lbm.foundation.v1.MsgGrantResponse)
11811176
- [MsgLeaveFoundation](#lbm.foundation.v1.MsgLeaveFoundation)
@@ -17132,21 +17127,6 @@ EventFundTreasury is an event emitted when one funds the treasury.
1713217127

1713317128

1713417129

17135-
<a name="lbm.foundation.v1.EventGovMint"></a>
17136-
17137-
### EventGovMint
17138-
EventGovMint is an event emitted when the minter mint coins to the treasury.
17139-
17140-
17141-
| Field | Type | Label | Description |
17142-
| ----- | ---- | ----- | ----------- |
17143-
| `amount` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated | |
17144-
17145-
17146-
17147-
17148-
17149-
1715017130
<a name="lbm.foundation.v1.EventGrant"></a>
1715117131

1715217132
### EventGrant
@@ -17332,7 +17312,6 @@ GenesisState defines the foundation module's genesis state.
1733217312
| `votes` | [Vote](#lbm.foundation.v1.Vote) | repeated | votes is the list of votes. |
1733317313
| `authorizations` | [GrantAuthorization](#lbm.foundation.v1.GrantAuthorization) | repeated | grants |
1733417314
| `pool` | [Pool](#lbm.foundation.v1.Pool) | | pool |
17335-
| `gov_mint_left_count` | [uint32](#uint32) | | gov_mint_count_left is the remaining number of times for gov_mint. |
1733617315

1733717316

1733817317

@@ -17396,31 +17375,6 @@ QueryFoundationInfoResponse is the Query/FoundationInfo response type.
1739617375

1739717376

1739817377

17399-
<a name="lbm.foundation.v1.QueryGovMintRequest"></a>
17400-
17401-
### QueryGovMintRequest
17402-
QueryGovMintRequest is the Query/GovMint request type.
17403-
17404-
17405-
17406-
17407-
17408-
17409-
<a name="lbm.foundation.v1.QueryGovMintResponse"></a>
17410-
17411-
### QueryGovMintResponse
17412-
QueryGovMintResponse is the Query/GovMint response type.
17413-
17414-
17415-
| Field | Type | Label | Description |
17416-
| ----- | ---- | ----- | ----------- |
17417-
| `leftCount` | [uint32](#uint32) | | leftCount is the left count of GovMint. |
17418-
17419-
17420-
17421-
17422-
17423-
1742417378
<a name="lbm.foundation.v1.QueryGrantsRequest"></a>
1742517379

1742617380
### QueryGrantsRequest
@@ -17745,7 +17699,6 @@ Query defines the gRPC querier service for foundation module.
1774517699
| `Votes` | [QueryVotesRequest](#lbm.foundation.v1.QueryVotesRequest) | [QueryVotesResponse](#lbm.foundation.v1.QueryVotesResponse) | Votes queries a vote by proposal. | GET|/lbm/foundation/v1/proposals/{proposal_id}/votes|
1774617700
| `TallyResult` | [QueryTallyResultRequest](#lbm.foundation.v1.QueryTallyResultRequest) | [QueryTallyResultResponse](#lbm.foundation.v1.QueryTallyResultResponse) | TallyResult queries the tally of a proposal votes. | GET|/lbm/foundation/v1/proposals/{proposal_id}/tally|
1774717701
| `Grants` | [QueryGrantsRequest](#lbm.foundation.v1.QueryGrantsRequest) | [QueryGrantsResponse](#lbm.foundation.v1.QueryGrantsResponse) | Returns list of authorizations, granted to the grantee. | GET|/lbm/foundation/v1/grants/{grantee}/{msg_type_url}|
17748-
| `GovMint` | [QueryGovMintRequest](#lbm.foundation.v1.QueryGovMintRequest) | [QueryGovMintResponse](#lbm.foundation.v1.QueryGovMintResponse) | GovMint queries the left count of gov mint. | GET|/lbm/foundation/v1/gov_mint|
1774917702

1775017703
<!-- end services -->
1775117704

@@ -17810,32 +17763,6 @@ MsgFundTreasuryResponse is the Msg/FundTreasury response type.
1781017763

1781117764

1781217765

17813-
<a name="lbm.foundation.v1.MsgGovMint"></a>
17814-
17815-
### MsgGovMint
17816-
MsgGovMint is the Msg/GovMint request type.
17817-
17818-
17819-
| Field | Type | Label | Description |
17820-
| ----- | ---- | ----- | ----------- |
17821-
| `authority` | [string](#string) | | authority is the address of the privileged account. |
17822-
| `amount` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated | |
17823-
17824-
17825-
17826-
17827-
17828-
17829-
<a name="lbm.foundation.v1.MsgGovMintResponse"></a>
17830-
17831-
### MsgGovMintResponse
17832-
MsgGovMintResponse is the Msg/GovMint response type.
17833-
17834-
17835-
17836-
17837-
17838-
1783917766
<a name="lbm.foundation.v1.MsgGrant"></a>
1784017767

1784117768
### MsgGrant
@@ -18148,7 +18075,6 @@ Msg defines the foundation Msg service.
1814818075
| `LeaveFoundation` | [MsgLeaveFoundation](#lbm.foundation.v1.MsgLeaveFoundation) | [MsgLeaveFoundationResponse](#lbm.foundation.v1.MsgLeaveFoundationResponse) | LeaveFoundation allows a member to leave the foundation. | |
1814918076
| `Grant` | [MsgGrant](#lbm.foundation.v1.MsgGrant) | [MsgGrantResponse](#lbm.foundation.v1.MsgGrantResponse) | Grant grants the provided authorization to the grantee with authority of the foundation. If there is already a grant for the given (grantee, Authorization) tuple, then the grant will be overwritten. | |
1815018077
| `Revoke` | [MsgRevoke](#lbm.foundation.v1.MsgRevoke) | [MsgRevokeResponse](#lbm.foundation.v1.MsgRevokeResponse) | Revoke revokes any authorization corresponding to the provided method name that has been granted to the grantee. | |
18151-
| `GovMint` | [MsgGovMint](#lbm.foundation.v1.MsgGovMint) | [MsgGovMintResponse](#lbm.foundation.v1.MsgGovMintResponse) | GovMint defines a gov mint coins to the treasury. | |
1815218078

1815318079
<!-- end services -->
1815418080

‎proto/lbm/foundation/v1/event.proto

-6
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,3 @@ message EventRevoke {
9292
// message type url for which an autorization is revoked.
9393
string msg_type_url = 2;
9494
}
95-
96-
// EventGovMint is an event emitted when the minter mint coins to the treasury.
97-
message EventGovMint {
98-
repeated cosmos.base.v1beta1.Coin amount = 1
99-
[(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/line/lbm-sdk/types.Coins"];
100-
}

0 commit comments

Comments
 (0)