Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

React 16 support? #166

Closed
TomiS opened this issue Dec 11, 2017 · 10 comments
Closed

React 16 support? #166

TomiS opened this issue Dec 11, 2017 · 10 comments

Comments

@TomiS
Copy link
Contributor

TomiS commented Dec 11, 2017

Any plans? :)

@rnicholus
Copy link
Member

such as?

@TomiS
Copy link
Contributor Author

TomiS commented Dec 11, 2017

Atm. this lib gives "unmet peer dependency" warning when installed with React 16. Might be enough to just update
https://github.com/FineUploader/react-fine-uploader/blob/master/package.json#L24
to allow version 16 and up.

@rnicholus
Copy link
Member

It needs to be tested w/ React 16 first. What else are you seeing? What have you tried?

@TomiS
Copy link
Contributor Author

TomiS commented Dec 11, 2017

Based on very quick test at least Dropzone seems to work. But I just started updating our app to React 16 so cannot really say anything conclusive yet. I keep my eyes open though.

@rnicholus
Copy link
Member

I welcome a pull request with this change and information detailing your manual tests. If all looks well, I see no reason to hold up this update. I also want to be sure all dependencies are compatible too.

@Dog
Copy link
Contributor

Dog commented Dec 24, 2017

I just tried to bring up this package from scratch with React 16. So far the only trouble I ran into was I needed to manually run yarn add [email protected] because yarn fails with a version 1.x.x.

This caused the below Error:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

@Dog Dog mentioned this issue Dec 24, 2017
@GazzaHazza
Copy link

Any updates on this?

@rnicholus
Copy link
Member

No, sorry. I'm hoping to find some time in the near future to more consistently maintain this and other FU libraries. There is also the possibility that a second maintainer will join soon.

@rnicholus
Copy link
Member

Please see #171 (comment)

@rnicholus
Copy link
Member

if someone can confirm that https://github.com/Dog/react-fine-uploader/tree/patch-1 fixes all React 16 issues, i'll release a new version.

Please also see #174

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants