Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send program event to *single* node which has siblings #366

Open
steve-the-edwards opened this issue Jun 30, 2015 · 6 comments
Open

Comments

@steve-the-edwards
Copy link

Program events are sent down through the tree, but only to the children of the node specified by path. Can a single node be addressed by path (as well as its children).

This would make emit() similar to how show()/hide() work currently.

@steve-the-edwards steve-the-edwards changed the title Cannot send program event to *single* leaf node which has siblings Cannot send program event to *single* node which has siblings Jun 30, 2015
@solomon-gumball
Copy link
Contributor

@alexanderGugel @DnMllr what are your thoughts on this?

@michaelobriena
Copy link
Member

@DnMllr Can you take a look at this?

@DnMllr
Copy link
Contributor

DnMllr commented Jul 7, 2015

Is the problem that the node itself doesn't get the event, only its children? In that case we should probably alter the convention.

@alexanderGugel
Copy link
Member

I think we should change the behavior of Dispatch#dispatch. I think it's more intuitive that it emits an event on all children including the node itself.

@steve-the-edwards
Copy link
Author

+1. I totally agree on that behaviour being more intuitive: event on node specified by path, and all children.

@jd-carroll
Copy link
Contributor

This issue can be closed as it has landed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants