Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dialogue export script #5

Closed
FWDekker opened this issue Sep 19, 2019 · 0 comments
Closed

Clean up dialogue export script #5

FWDekker opened this issue Sep 19, 2019 · 0 comments
Assignees
@FWDekker
Labels
code-quality Code changes without behavior changes

Comments

@FWDekker
Copy link
Owner

FWDekker commented Sep 19, 2019 •
edited
Loading

The dialogue export script writes directly to outputLines. Instead, it should build and finally return a string which is added to outputLines by the caller. Additionally, the addQuest function should be split up into multiple functions if possible.
@FWDekker FWDekker added the code-quality Code changes without behavior changes label Sep 19, 2019
@FWDekker FWDekker self-assigned this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FWDekker FWDekker

Labels
code-quality Code changes without behavior changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FWDekker