Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SublayerConnection #22

Open
tomcattiger1230 opened this issue Aug 31, 2021 · 0 comments
Open

SublayerConnection #22

tomcattiger1230 opened this issue Aug 31, 2021 · 0 comments

Comments

@tomcattiger1230
Copy link

Hello,
Thank you for your implementation. I have a question about the SublayerConnection for the residual connection. Based on the original paper, one use
dropout(norm(x+ sublayer(x))). But in your implementation one has x+dropout(sublayer(norm(x))) instead. Is my understanding correct? Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomcattiger1230