-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Multiple client instances launched after incorrect password attempts #3301
Comments
I think this is an issue with the recursive mess in
faf-java-commons#FafLobbyClient
downlords-faf-client/src/main/java/com/faforever/client/remote/FafServerAccessor.java Lines 200 to 202 in c3f57c9
downlords-faf-client/src/main/java/com/faforever/client/game/GameRunner.java Lines 299 to 305 in c3f57c9
3.1. and effectively here (line 225) => downlords-faf-client/src/main/java/com/faforever/client/game/GameRunner.java Lines 214 to 227 in c3f57c9
And it blocks until the server emmits And the more you click to join game and type in wrong password, the more subscribers/CompletableFuture stack up. When you finally make the server return |
Describe the Bug
Entering incorrect passwords for a protected lobby one or more times causes that many game instances to launch when successfully joining any lobby afterwards.
Bug was reported via tech-support (Link to Discord Thread)
I can reproduce the bug as well.
Log file or Error Message
ice-adapter.log
client.log
Reproduce the bug
How to reproduce:
Expected Behavior
Only one client instance should spawn when entering a lobby
Screenshots
Additional context
No response
Which Operating System are you using?
Windows
The text was updated successfully, but these errors were encountered: