Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General update #34

Open
webketje opened this issue May 18, 2022 · 3 comments
Open

General update #34

webketje opened this issue May 18, 2022 · 3 comments

Comments

@webketje
Copy link

Hi there, would you still update and publish this vital plugin if I create a PR modernizing it and adding a bunch of features?

  • Better JSdocs
  • replacing new Buffer with Buffer.from
  • updating dependencies
  • Add an engines.node property to package.json
  • Add an peerDependencies.metalsmith property to package.json
  • providing support for multiple sitemaps (eg, per language)
@njbraun
Copy link
Member

njbraun commented May 23, 2022

Please feel free to make a PR with those features! Much appreciated.

@webketje
Copy link
Author

@njbraun is the Travis CI still active, or should this be migrated to GH actions? WIP here: https://github.com/webketje/metalsmith-sitemap/commits/master

@webketje
Copy link
Author

webketje commented Jun 1, 2022

See #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njbraun @webketje