Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive hostname from Metalsmith metadata if available #33

Open
codeguy opened this issue Apr 9, 2020 · 1 comment
Open

Derive hostname from Metalsmith metadata if available #33

codeguy opened this issue Apr 9, 2020 · 1 comment

Comments

@codeguy
Copy link

codeguy commented Apr 9, 2020

Rather than require a hostname opt, can you also look and see if it is available from the metalsmith metadata? This way I can define a hostname from an earlier plugin.

Affected lines:

https://github.com/ExtraHop/metalsmith-sitemap/blob/master/lib/index.js#L48-L50

Happy to send a pull request if you authorize the change.

@njbraun
Copy link
Member

njbraun commented Apr 9, 2020

Sounds like a great feature @codeguy ! If you submit a PR, we can take a look.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants