Ignore unselectable text from selection #27421

bernhardoj · 2023-09-14T09:10:46Z

Details

On the web, there is some text that is not selectable but we can still copy it when using copy shortcut CTRL+C.

Fixed Issues

$ #26694
PROPOSAL: #26694 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Web
NOTE: if you encounter a case where the pasted text contains some random style text, it's a known issue that won't be fixed based on this comment
Emoji reaction:

Send any message to a chat
Add an emoji reaction to the message
Triple click the message to select it
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain any emoji

Menu item:

Open Settings > Profile > Timezone
Turn on the automatic timezone
Select the Timezone title text and drag it to the bottom of the timezone name
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the timezone name

Multiple Avatars 1:

Open workspace invite page
Select more than 8 users to invite and press Next
Drag a text selection from the header to the bottom of +N text of the avatar overlay
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the +N text

Multiple Avatars 2:

Create a new group chat with >= 3 members and open it
Drag a text selection from the first user name on the chat header to the left of +N text of the avatar
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the +N text

Calendar:

Open Settings > Profile > Personal Details > Date of birth
Drag a text selection from "Date of birth" title to the bottom of the Save button text
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain any text from the calendar and the Save button

Edited message:

Send any message to a chat
Edit the message
Select the message along with the (edited) text
Press CTRL+C and paste it to composer or any text editor
Verify the pasted message does not contain any space

Reply:

Send any message to a chat
Add a new reply to the message you sent
Drag a text selection from the message to the bottom of "N Reply" text
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain "N Reply" text and its timestamp

List item 1:

Open Settings > Profile > Personal Details > Pronouns
Search for any pronouns
Drag a text selection from the Pronouns title to the pronouns list
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the pronouns list

List item 2:

Open workspace members page
Drag a text selection from Members title to the members list
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the members list and the Select all text

New message:

Open any chat with a few messages
Mark the last message as unread
Scroll up to show the "New message" floating view
Drag a text selection from the user name on the header to the end of "New message" text
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain "New message"

Text input prefix

Press FAB and choose New room
Drag a text selection from the new room title to the bottom of the "#" prefix text
Press CTRL+C and paste it to composer or any text editor
Verify the pasted text does not contain the prefix ("#") text

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Emoji reaction

emoji.mov

List 1 (RadioListItem)

radio.list.item.mov

List 2 (BaseSelectionList + UserListItem)

selection.list.mov

MenuItem (timezone)

timezone.menuitem.mov

MultipleAvatars

multiple.avatar_2.mov

multiple_avatar_1.mov

CalendarPicker + Button

button.+.calendar.mov

Edited text

edited.mov

Thread reply

reply.mov

Floating New message

new.message.mov

Prefix

prefix.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-14T09:10:50Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-09-14T09:10:51Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-09-14T09:23:04Z

The issue only happens when using the copy shortcut, so the fix is only applied to a component with a user-select none style on the web (large screen). However, we still have 1 component that I haven't applied the fix yet, that is OfflineWithFeedback. The reason is, that OfflineWithFeedback is used in some places where the children override the user-select none to user-select text, for example, BaseAnchorForCommentsOnly.

This means, that even though the OfflineWithFeedback is not selectable, the BaseAnchorForCommentsOnly is still selectable. If we ignore the selection from all OfflineWithFeedback, selecting anchor text and copying it will not include the anchor text, as shown below:

Screen.Recording.2023-09-14.at.17.18.00.mov

I don't know the reason why we are setting the user-select text to BaseAnchorForCommentsOnly or to all markdown text actually (in BaseHTMLEngineProvider), but the question is, do we ignore it or add new props to OfflineWithFeedback (called shouldIgnoreSelectionOnDelete, defaults true) and pass it as false in BaseAnchorForCommentsOnly case?

dataSet: {[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: props.shouldIgnoreSelectionOnDelete}

0xmiros

Seems like you put dataSet code on all views where selectable={false} is passed.
Can we put in base component - Text, BaseGenericPressable so if selectable={false} is passed, add dataSet prop manually?

bernhardoj · 2023-09-15T01:40:00Z

@0xmiroslav that's actually a nice idea, but I see that react-native-web 0.19 deprecated selectable props and we are in the process of updating it to >= 0.19. I'm afraid that if we apply the dataSet in the Text/BaseGenericPressable and set the value based on selectable, it will be removed along with selectable (or may not be removed at all which makes the value always false, or undefined).

0xmiros · 2023-09-15T07:06:02Z

@0xmiroslav that's actually a nice idea, but I see that react-native-web 0.19 deprecated selectable props and we are in the process of updating it to >= 0.19. I'm afraid that if we apply the dataSet in the Text/BaseGenericPressable and set the value based on selectable, it will be removed along with selectable (or may not be removed at all which makes the value always false, or undefined).

Makes sense 👍

0xmiros · 2023-09-15T20:13:37Z

@bernhardoj please fix conflict

bernhardoj · 2023-09-16T03:59:23Z

Conflicts solved

0xmiros · 2023-09-16T19:34:44Z

src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js

@@ -28,6 +29,7 @@ function EditedRenderer(props) {
            <Text
                selectable={false}
                style={[styles.w1, styles.userSelectNone]}
+                dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}


Personally I think adding space (messsage (edited)) is better than no space (messsage(edited))

yeah, me too, but I don't know why we added userSelectNone to the space.

Maybe to fix these:
#15194
#23402

huh interesting, let's keep it then

0xmiros · 2023-09-16T19:35:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

web2.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

0xmiros

LGTM!

Li357

Looks good, thanks for the thorough testing here!

OSBotify · 2023-09-18T06:02:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

getusha · 2023-09-18T07:18:26Z

@0xmiroslav that's actually a nice idea, but I see that react-native-web 0.19 deprecated selectable props and we are in the process of #24482. I'm afraid that if we apply the dataSet in the Text/BaseGenericPressable and set the value based on selectable, it will be removed along with selectable (or may not be removed at all which makes the value always false, or undefined).

Thank you for taking this into consideration @bernhardoj @0xmiroslav

OSBotify · 2023-09-18T10:39:06Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-20T08:11:36Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ignore unselectable text from selection

58918c0

bernhardoj requested a review from a team as a code owner September 14, 2023 09:10

melvin-bot bot removed the request for review from a team September 14, 2023 09:10

melvin-bot bot requested a review from 0xmiros September 14, 2023 09:10

0xmiros reviewed Sep 14, 2023

View reviewed changes

Merge branch 'main' into fix/26694-ignore-selection

113546a

0xmiros reviewed Sep 16, 2023

View reviewed changes

0xmiros approved these changes Sep 16, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 September 16, 2023 19:36

Li357 approved these changes Sep 18, 2023

View reviewed changes

Li357 merged commit 5d4b49b into Expensify:main Sep 18, 2023

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

lanitochka17 mentioned this pull request Sep 18, 2023

Web - Copied text from Invite screen contain names of the avatars when paste to Notepad #27723

Closed

6 tasks

melvin-bot bot mentioned this pull request Sep 20, 2023

[HOLD for payment 2023-09-27] [$500] Chat - Emojis are selected when message is copied by selecting #26694

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore unselectable text from selection #27421

Ignore unselectable text from selection #27421

bernhardoj commented Sep 14, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

bernhardoj commented Sep 14, 2023

0xmiros left a comment

bernhardoj commented Sep 15, 2023

0xmiros commented Sep 15, 2023

0xmiros commented Sep 15, 2023

bernhardoj commented Sep 16, 2023

0xmiros Sep 16, 2023

bernhardoj Sep 17, 2023

0xmiros Sep 17, 2023

bernhardoj Sep 17, 2023

0xmiros commented Sep 16, 2023 •

edited

Loading

0xmiros left a comment

Li357 left a comment

OSBotify commented Sep 18, 2023

getusha commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

Ignore unselectable text from selection #27421

Ignore unselectable text from selection #27421

Conversation

bernhardoj commented Sep 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

bernhardoj commented Sep 14, 2023

0xmiros left a comment

Choose a reason for hiding this comment

bernhardoj commented Sep 15, 2023

0xmiros commented Sep 15, 2023

0xmiros commented Sep 15, 2023

bernhardoj commented Sep 16, 2023

0xmiros Sep 16, 2023

Choose a reason for hiding this comment

bernhardoj Sep 17, 2023

Choose a reason for hiding this comment

0xmiros Sep 17, 2023

Choose a reason for hiding this comment

bernhardoj Sep 17, 2023

Choose a reason for hiding this comment

0xmiros commented Sep 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

Li357 left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 18, 2023

getusha commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

bernhardoj commented Sep 14, 2023 •

edited

Loading

0xmiros commented Sep 16, 2023 •

edited

Loading