From c2f3b78591b6aea4dd75c6a099c90a2b68abfd97 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Wed, 2 Aug 2023 16:45:44 +0200 Subject: [PATCH 1/2] Fix memoization --- src/pages/home/report/ReportActionItem.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/pages/home/report/ReportActionItem.js b/src/pages/home/report/ReportActionItem.js index 8c6defcb2951..0952ec468f9f 100644 --- a/src/pages/home/report/ReportActionItem.js +++ b/src/pages/home/report/ReportActionItem.js @@ -612,10 +612,8 @@ export default compose( lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') && prevProps.translate === nextProps.translate && // TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport - ReportUtils.isTaskReport(prevProps.report) && - prevProps.action.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED && - ReportUtils.isTaskReport(nextProps.report) && - nextProps.action.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED && + ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) && + prevProps.action.actionName === nextProps.action.actionName && prevProps.report.reportName === nextProps.report.reportName && prevProps.report.description === nextProps.report.description && ReportUtils.isCompletedTaskReport(prevProps.report) === ReportUtils.isCompletedTaskReport(nextProps.report) && From afd5ddbce41a23c26b1ebfc26ba7ea2ec3752f27 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Thu, 3 Aug 2023 09:21:31 +0200 Subject: [PATCH 2/2] Fix lint --- src/pages/home/report/ReportActionItem.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/home/report/ReportActionItem.js b/src/pages/home/report/ReportActionItem.js index 0952ec468f9f..11cb7982b9a9 100644 --- a/src/pages/home/report/ReportActionItem.js +++ b/src/pages/home/report/ReportActionItem.js @@ -613,7 +613,7 @@ export default compose( prevProps.translate === nextProps.translate && // TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) && - prevProps.action.actionName === nextProps.action.actionName && + prevProps.action.actionName === nextProps.action.actionName && prevProps.report.reportName === nextProps.report.reportName && prevProps.report.description === nextProps.report.description && ReportUtils.isCompletedTaskReport(prevProps.report) === ReportUtils.isCompletedTaskReport(nextProps.report) &&