Tighten up search results expectations

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Problem

There are a number of different types of chats and users, and it's not clearly documented anywhere the order in which those should appear when searching for them.

Solution

1. First, clearly and thoroughly define the results ordering, accounting for:
   1. Exact matches
   2. DM's, group chats, policy default rooms, workspace chats, user-created rooms
   3. How the order might change for the New Chat or New Group pages, and for users that don't yet have Expensify accounts.
2. Create unit tests to cover all those expected results.
3. (optional but ideal) Create some kind of benchmarking for search results and test them with an account with many report participants.
4. Attempt to DRY up and generalize all the OptionsListUtils search logic we have now.
5. Patch logic as necessary to make tests pass.
6. Monitor the benchmarks created in step 3 and ensure that we aren't slowing down search by a significant amount. Make it faster if necessary.

View all open jobs on GitHub

[roryabraham]

Going to make this internal for step 1 only, then will pass off to contributors.

[roryabraham]

No update here

[roryabraham]

Was hoping to get to this, but going to have to punt again.

[roryabraham]

Have to punt again 😞

[roryabraham]

No update again, focusing on Offline First and other N7 priorities 😭

[roryabraham]

Again no update, considering closing this. It needs to be done, but is a slog and difficult to prioritize. Could be an interesting project for a contributor aspiring to be a C+ (because it involves not only writing tests and code but leading slack discussions to generate consensus).

[roryabraham]

Working a lot on refactoring related components in this large PR. No update on this.

[roryabraham]

No update again.

[roryabraham]

Going to switch this to monthly until things settle down a bit. Seems pretty valuable, but not urgent.

[roryabraham]

No update here

[roryabraham]

Going to just close this. Since opening this issue we've seen an increase in unit tests around this flow and also a number of regression tests added to TF.