Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS/Android - Text with over 6 makes message box scroll #7320

Closed
kbecciv opened this issue Jan 19, 2022 · 7 comments
Closed

IOS/Android - Text with over 6 makes message box scroll #7320

kbecciv opened this issue Jan 19, 2022 · 7 comments
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Open any chat
  3. Type text with more than 6 lines

Expected Result:

Text with 2+ lines is not scrolling

Actual Result:

Text with over 6 lines is scrolling inside the message box

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.31.0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing: #7210

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 19, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flodnv
Copy link
Contributor

flodnv commented Jan 19, 2022

@kursat any thoughts on this one? Can you take it?

@flodnv flodnv removed their assignment Jan 19, 2022
@kursat
Copy link
Contributor

kursat commented Jan 19, 2022

Hey @flodnv, I checked and I am sure its not because of my PR. The cause of problem can be this:

lineHeight of textarea is 20 but, max height for the component is set to 116. Changing it to 120 fixes the problem (x6 rows), but I am not sure is this the correct solution.

@parasharrajat is it a good solution to set COMPOSER_MAX_HEIGHT to 120, in src/CONST.js file? Does that cause side effects?

@parasharrajat
Copy link
Member

Sorry, What's going on here?

"4. Verify text with 2+ lines is not scrolling."

What are we expecting here? The text should not scroll> 😕

@parasharrajat
Copy link
Member

COMPOSER_MAX_HEIGHT is used to set the max height on the composer and It should not cause any issue except that composer height will increase and swipe to a close distance as well. 4px does not make much difference.

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 19, 2022

Reported issue does not sound related to the #7210

On staging test flight or on production on mobile once certain lines of text is entered the message box becomes scrollable. The original issue was a miscalculation or rows specific to firefox but i believe we are good since the line numbers are correct wrt to the text so i'm closing out the issue.

Plus i see the same behavior on production so i'm not sure if you meant a different test. Closing issue for now but feel free to reopen if there are more details to clarify our questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants