-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS/Android - Text with over 6 makes message box scroll #7320
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @flodnv ( |
@kursat any thoughts on this one? Can you take it? |
Hey @flodnv, I checked and I am sure its not because of my PR. The cause of problem can be this: lineHeight of textarea is 20 but, max height for the component is set to 116. Changing it to 120 fixes the problem (x6 rows), but I am not sure is this the correct solution. @parasharrajat is it a good solution to set COMPOSER_MAX_HEIGHT to 120, in src/CONST.js file? Does that cause side effects? |
Sorry, What's going on here?
What are we expecting here? The text should not scroll> 😕 |
COMPOSER_MAX_HEIGHT is used to set the max height on the composer and It should not cause any issue except that composer height will increase and swipe to a close distance as well. 4px does not make much difference. |
Reported issue does not sound related to the #7210 On staging test flight or on production on mobile once certain lines of text is entered the message box becomes scrollable. The original issue was a miscalculation or rows specific to firefox but i believe we are good since the line numbers are correct wrt to the text so i'm closing out the issue. Plus i see the same behavior on production so i'm not sure if you meant a different test. Closing issue for now but feel free to reopen if there are more details to clarify our questions. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Text with 2+ lines is not scrolling
Actual Result:
Text with over 6 lines is scrolling inside the message box
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.31.0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Issue was found when executing: #7210
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: