[HOLD for payment 2021-11-04] [HOLD for payment 2021-10-30] VBA - User can proceed to personal info after clearing address in company info page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log in with expensifail account
3. Go to Workspace and Click on Connect Bank account
4. Log in with Chase credentials
5. In the company info page select any autofill address and clear the address
6. Fill in rest of the fields and hit save and continue

Expected Result:

Error message appears for missing address in Company address

Actual Result:

User can proceed to personal info page

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.8-0
Reproducible in staging?: Yes
Reproducible in production?: No credentials to check
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.48.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[akshayasalvi]

I tried to look at this issue but it seems the Google Places cannot be accessed from localhost. Gives a cross-origin error.

[stitesExpensify]

Looking into this now

[Santhosh-Sellavel]

@stitesExpensify
the address is not validated in this below method
We can add address validation using this.getFormattedAddressValue() != '' and show appropriate errors.

Validated.

[stitesExpensify]

I'm wondering if this change broke it 7fa7ab7#diff-40ada854d0b6039d4db7da6cede12f7be0cf7d113cc16c8cbc638af4bd0121d4R186 all other fields are set with a keyword, this one is not anymore

[Santhosh-Sellavel]

Proposal

App/src/components/AddressSearch.js

Lines 105 to 110 in dd9e492

	textInputProps={{
	InputComp: ExpensiTextInput,
	label: props.label,
	containerStyles: props.containerStyles,
	errorText: props.errorText,
	}}

Along lines above need pass,
onChangeText: () => saveLocationDetails({}),

We are not detecting textInput changes and updating state.
@stitesExpensify

Fixed:

Simulator.Screen.Recording.-.iPhone.12.-.2021-10-19.at.02.44.04.mp4

[stitesExpensify]

Nice! Seems like a good solution to me

[Santhosh-Sellavel]

Can I submit a PR @stitesExpensify

[stitesExpensify]

Hold on for now, I don't know what our process is when someone who is not the author wants to fix a deploy blocker. Checking internally...

[stitesExpensify]

Hey @Santhosh-Sellavel I'm going to make this external and get you hired for your solution

[MelvinBot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Santhosh-Sellavel]

@stitesExpensify
Let me know when I can start PR. Thanks!

[NicMendonca]

Upwork job: https://www.upwork.com/jobs/~01f52496616abc0a16

[stitesExpensify]

@Santhosh-Sellavel go ahead an apply, then when you are accepted you can make your pR

[Santhosh-Sellavel]

Applied for the job @NicMendonca

[NicMendonca]

@Santhosh-Sellavel hired!

[Santhosh-Sellavel]

@stitesExpensify Assign me this one!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.8-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed address clear detected & modified the state #5954

If no regressions arise, payment will be issued on 2021-10-30. 🎊

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.10-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed address clear detected & modified the state #5954

If no regressions arise, payment will be issued on 2021-11-04. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[NicMendonca]

Paid!