Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the emails and phone numbers field header padding on the Invite new members page #5795

Closed
trjExpensify opened this issue Oct 13, 2021 · 5 comments
Assignees
Labels
Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Oct 13, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log-in to NewDot
  2. Tap + and create a new workspace
  3. Go to the manage members page
  4. click invite
  5. enter an email address
  6. delete an email address
  7. observe the field header

Expected Result:

The padding between the ghost text and the field header should remain in tact after the value is removed.

Actual Result:

Deleting the value from the emails and phone numbers field causes the field header to lose padding. This causes the ghost text and the header to become jumbled together.

Workaround:

Yes, still workable.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.7-6 (staging)
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
email and phone numbers padding
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/180880
Issue reported by: trjexpensify
Slack conversation: n/a, N6 testing

Upwork URL: https://www.upwork.com/jobs/~0189e4cdaf9cce6a84

View all open jobs on GitHub

@trjExpensify trjExpensify added Exported Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Oct 13, 2021
@MelvinBot MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 labels Oct 13, 2021
@parasharrajat
Copy link
Member

parasharrajat commented Oct 13, 2021

We don't need this issue as I am working on #4775 which will replace the component UI.

@parasharrajat
Copy link
Member

Also, this issue is affecting all the inputs in the app and it is just fixed for @Jag96 here #5789

@trjExpensify
Copy link
Contributor Author

I think @kevinksullivan caught up with Joe last night and it was determined that it might not be covered. Regardless, I agree the problem goes away with the other issue.

@Jag96
Copy link
Contributor

Jag96 commented Oct 13, 2021

Yes, this will be fixed by #5789 before #4775 is done so we should be good here, closing

@Jag96 Jag96 closed this as completed Oct 13, 2021
@trjExpensify
Copy link
Contributor Author

trjExpensify commented Oct 13, 2021

Cool, let me take the job down then.

Edit: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants