Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-27] [$250] Bug: Going back and forth on multi connection page displays a disconnect prompt. #56385

Closed
yuwenmemon opened this issue Feb 4, 2025 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Feb 4, 2025

Bug; If you try to connect using the multi-connection page then go back and forth again, the disconnect prompt is always re-displayed.

Screen.Recording.2025-01-21.at.10.25.12.AM.mov

Fix attempt 1 (from @s77rt): If I force going back to the correct route (without the integrationToDisconnect params, etc.), the bug is fixed but the navigation direction is not correct.

Screen.Recording.2025-01-21.at.10.28.27.AM.mov
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021895123531434085041
  • Upwork Job ID: 1895123531434085041
  • Last Price Increase: 2025-02-27
@yuwenmemon yuwenmemon added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Feb 4, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@yuwenmemon yuwenmemon removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 4, 2025
@yuwenmemon yuwenmemon self-assigned this Feb 4, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2025
@s77rt
Copy link
Contributor

s77rt commented Feb 8, 2025

Didn't look into this yet

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

@yuwenmemon, @s77rt, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 11, 2025
@s77rt
Copy link
Contributor

s77rt commented Feb 11, 2025

Will look into this today

@s77rt
Copy link
Contributor

s77rt commented Feb 11, 2025

Fix #56702

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title Bug: Going back and forth on multi connection page displays a disconnect prompt. [Due for payment 2025-02-27] Bug: Going back and forth on multi connection page displays a disconnect prompt. Feb 20, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 20, 2025

@s77rt @greg-schroeder @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@greg-schroeder greg-schroeder changed the title [Due for payment 2025-02-27] Bug: Going back and forth on multi connection page displays a disconnect prompt. [HOLD for payment 2025-02-27] Bug: Going back and forth on multi connection page displays a disconnect prompt. Feb 21, 2025
@s77rt
Copy link
Contributor

s77rt commented Feb 24, 2025

No checklist is needed. This is a follow up from NSQS PR #55049

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Payment Summary

Upwork Job

  • Reviewer: @s77rt owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@greg-schroeder
Copy link
Contributor

@s77rt were you paid in one of the 4-5 other issues related to this? Or is this the one for payment?

I saw you were listed as eligible for payment via manual request here

@s77rt
Copy link
Contributor

s77rt commented Feb 27, 2025

@greg-schroeder Payment for NSQS will be handled after the NSQS project is complete. However we should pay @DylanDylann as he reviewed the PR.

@greg-schroeder
Copy link
Contributor

I'm going to make this External again briefly to try and create an Upwork job

@greg-schroeder greg-schroeder removed the External Added to denote the issue can be worked on by a contributor label Feb 27, 2025
@greg-schroeder greg-schroeder changed the title [HOLD for payment 2025-02-27] Bug: Going back and forth on multi connection page displays a disconnect prompt. [HOLD for payment 2025-02-27] [$250] Bug: Going back and forth on multi connection page displays a disconnect prompt. Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021895123531434085041

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@greg-schroeder
Copy link
Contributor

Offer sent to @DylanDylann for reviewer role!

@greg-schroeder
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

3 participants