Company cards - After enabling company card, tapping new card directs to hmm not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.94-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - more features - enable company card
3. Tap members
4. Tap admin - new card

Expected Result:

After enabling company card, tapping new card must not direct to hmm not here page

Actual Result:

After enabling company card, tapping new card directs to hmm not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6733491_1738693864435.Screenrecorder-2025-02-04-23-55-59-605.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After enabling company card, tapping new card directs to hmm not here page.

What is the root cause of that problem?

1. The New Card button is shown based on these conditions:
   shouldShowCardsSection
   

   App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

   Lines 336 to 340 in 386ea3e

   	<MenuItem
   	title={translate('workspace.expensifyCard.newCard')}
   	icon={Expensicons.Plus}
   	onPress={handleIssueNewCard}
   	/>

   
   The issue is that !!policy?.areExpensifyCardsEnabled is false.

2. The IssueNewCardPage is only displayed if !!policy?.areExpensifyCardsEnabled is true:
   

   App/src/pages/workspace/expensifyCard/issueNew/IssueNewCardPage.tsx

   Line 75 in 1e4ff8a

   featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED}

What changes do you think we should make in order to solve the problem?

1. Add a condition to show the New Card button only if !!policy?.areExpensifyCardsEnabled is true, like:

{!!policy?.areExpensifyCardsEnabled && (
    <MenuItem
        title={translate('workspace.expensifyCard.newCard')}
        icon={Expensicons.Plus}
        onPress={handleIssueNewCard}
    />
)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write test for the WorkspaceMemberDetailsPage if the !!policy?.areExpensifyCardsEnabled is false, then the New Card button should not be displayed

What alternative solutions did you explore? (Optional)

Alternative 1:
If the !!policy?.areExpensifyCardsEnabled is false, we can disable the new card button, instead of hiding it.

Alternative 2:
If it is allowed for a user to add a new card if the !!policy?.areCompanyCardsEnabled is true, then we can add this condition here :

App/src/pages/workspace/expensifyCard/issueNew/IssueNewCardPage.tsx

Line 75 in 1e4ff8a

featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED}

like:

            featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED ||CONST.POLICY.MORE_FEATURES.ARE_COMPANY_CARDS_ENABLED }

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - After enabling company card, tapping new card directs to hmm not here page

What is the root cause of that problem?

• The "New card" button is displayed when shouldShowCardsSection is true. This remains true even if areCompanyCardsEnabled is true. Upon clicking the button, it navigates to either WORKSPACE_MEMBER_NEW_CARD or WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Line 212 in 1e4ff8a

  const shouldShowCardsSection = (hasWorkspaceCardsAssigned || !!cardFeeds) && (!!policy?.areExpensifyCardsEnabled || !!policy?.areCompanyCardsEnabled);

  
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Lines 336 to 340 in 1e4ff8a

  	<MenuItem
  	title={translate('workspace.expensifyCard.newCard')}
  	icon={Expensicons.Plus}
  	onPress={handleIssueNewCard}
  	/>

• However, when navigating to WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW, a "Not Here" page is shown because areExpensifyCardsEnabled is not true.
  

  App/src/pages/workspace/expensifyCard/issueNew/IssueNewCardPage.tsx

  Line 75 in 1e4ff8a

  featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED}

What changes do you think we should make in order to solve the problem?

• We should only show the "New card" button when hasMultipleFeeds or areExpensifyCardsEnabled is true.

{(policy.areExpensifyCardsEnabled || hasMultipleFeeds) && (
    <MenuItem
        title={translate('workspace.expensifyCard.newCard')}
        icon={Expensicons.Plus}
        onPress={handleIssueNewCard}
    />
)}

• In addition, we also need to update the shouldShowCardsSection condition, currently it checks !!cardFeeds which will be always true since it contains a object with isLoading property, so we should check for any property in cardFeeds, and I think we should just change it to !!cardFeeds?.settings.
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Line 212 in 1e4ff8a

  const shouldShowCardsSection = (hasWorkspaceCardsAssigned || !!cardFeeds) && (!!policy?.areExpensifyCardsEnabled || !!policy?.areCompanyCardsEnabled);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)