Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HybridApp AdHoc runs fail if no Mobile-Expensify PR is provided #56369

Open
Julesssss opened this issue Feb 4, 2025 · 2 comments
Open

HybridApp AdHoc runs fail if no Mobile-Expensify PR is provided #56369

Julesssss opened this issue Feb 4, 2025 · 2 comments
Assignees
@Julesssss
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Feb 4, 2025 •
edited
Loading

Problem

When running an AdHoc HybridApp build, the run fails if no Mobile-Expensify PR is included in the description.

Example run: https://github.com/Expensify/App/actions/runs/13141580686/job/36669786276

Solution

We previously fell back to main and should do the same thing again. It looks like the bug occurs when the link is completely deleted instead of leaving the placeholder.
@Julesssss Julesssss self-assigned this Feb 4, 2025
@Julesssss
Copy link
Contributor Author

Hey @jnowakow, I think this regression occured after yesterday's PR.

@Julesssss Julesssss added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Feb 4, 2025
@Julesssss Julesssss mentioned this issue Feb 4, 2025
Draft
50 tasks
@Julesssss
Copy link
Contributor Author

I tried to fallback to main in this PR but have some unresolved formatting issues in my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julesssss