Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense details - Violation is not displayed on description field when opening IOU details #56310

Open
2 of 8 tasks
IuliiaHerets opened this issue Feb 4, 2025 · 21 comments
Open
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 4, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Money Requests

Action Performed:

  1. Create a workspace
  2. Create an IOU request in the workspace chat with a category (Advertising)
  3. Go to Reports page
  4. Go to workspace settings page > Categories
  5. Disable the category you have selected on step 2
  6. Return to Reports page
  7. Click on Review button of the money request

Expected Result:

Violation should be displayed on Category field on the first visit to the IOU details page

Actual Result:

Violation is not displayed on Category field on the first visit to the IOU details page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6732946_1738660825917.category_violations.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @michaelkwardrop
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 4, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 4, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Production behavior

bandicam.2025-02-04.11-42-58-458.mp4

@mjasikowski
Copy link
Contributor

I'll check a few PRs to see if this is connected

@mjasikowski
Copy link
Contributor

Unable to reproduce on dev or staging:

Screen.Recording.2025-02-04.at.13.17.32.mov

I suspect this may have something to do with Onyx update speed.

@samranahm
Copy link

@mjasikowski I can still repo this, here's how

  • make sure you don't already have any disabled category
  • Previous openReport expenses have been paid
Screen.Recording.2025-02-04.at.8.16.46.PM.mov

@mjasikowski
Copy link
Contributor

Will try to reproduce once again

@mjasikowski
Copy link
Contributor

Managed to reproduce, looking for a fix now

@mjasikowski
Copy link
Contributor

mjasikowski commented Feb 5, 2025

This is caused by #54455, creating a revert
FYI @Krishna2323 @rojiphil

@Krishna2323
Copy link
Contributor

@mjasikowski, if we have some time then I can try fixing this with a follow-up PR.

@mjasikowski
Copy link
Contributor

@Krishna2323 how long would it take for you to make a PR?

@Krishna2323
Copy link
Contributor

I think 2 hours should be enough for finding a solution and raising the PR but I will try to finish that asap.

@mjasikowski
Copy link
Contributor

all right, I think we can wait a couple of hours - I will most likely be done by that time so please post in #expensify-open-source when ready

@rojiphil
Copy link
Contributor

rojiphil commented Feb 5, 2025

PR is ready for internal review. Thanks.
cc @mjasikowski

@kavimuru
Copy link

kavimuru commented Feb 6, 2025

Not reproducible

Recording.571.mp4

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2025
@luacmartins
Copy link
Contributor

We reverted the original PR, please work on reimplementing the PR with the blocker in mind.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 11, 2025
@melvin-bot melvin-bot bot changed the title Expense details - Violation is not displayed on description field when opening IOU details [Due for payment 2025-02-18] Expense details - Violation is not displayed on description field when opening IOU details Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-18. 🎊

Copy link

melvin-bot bot commented Feb 11, 2025

@mjasikowski / @roryabraham @michaelkwardrop @mjasikowski / @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham roryabraham changed the title [Due for payment 2025-02-18] Expense details - Violation is not displayed on description field when opening IOU details Expense details - Violation is not displayed on description field when opening IOU details Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
9 participants