-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expense details - Violation is not displayed on description field when opening IOU details #56310
Comments
Triggered auto assignment to @mjasikowski ( |
Triggered auto assignment to @michaelkwardrop ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Production behavior bandicam.2025-02-04.11-42-58-458.mp4 |
I'll check a few PRs to see if this is connected |
Unable to reproduce on dev or staging: Screen.Recording.2025-02-04.at.13.17.32.movI suspect this may have something to do with Onyx update speed. |
@mjasikowski I can still repo this, here's how
Screen.Recording.2025-02-04.at.8.16.46.PM.mov |
Will try to reproduce once again |
Managed to reproduce, looking for a fix now |
This is caused by #54455, creating a revert |
@mjasikowski, if we have some time then I can try fixing this with a follow-up PR. |
@Krishna2323 how long would it take for you to make a PR? |
I think 2 hours should be enough for finding a solution and raising the PR but I will try to finish that asap. |
all right, I think we can wait a couple of hours - I will most likely be done by that time so please post in #expensify-open-source when ready |
PR is ready for internal review. Thanks. |
Not reproducible Recording.571.mp4 |
We reverted the original PR, please work on reimplementing the PR with the blocker in mind. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-18. 🎊 |
@mjasikowski / @roryabraham @michaelkwardrop @mjasikowski / @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop
App Component: Money Requests
Action Performed:
Expected Result:
Violation should be displayed on Category field on the first visit to the IOU details page
Actual Result:
Violation is not displayed on Category field on the first visit to the IOU details page
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6732946_1738660825917.category_violations.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @michaelkwardropThe text was updated successfully, but these errors were encountered: