Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - "Invite your team" task description is not styled correctly #56308

Closed
8 tasks done
IuliiaHerets opened this issue Feb 4, 2025 · 11 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account.
  3. Select Manage my team's expenses.
  4. Selecting any organization size and accounting software.
  5. Go to #admins
  6. Open task "Invite your team".
  7. Go back and open task "Create a workspace".

Expected Result:

"Invite your team" and "Create a workspace" task description will be styled correctly.

Actual Result:

"Invite your team" and "Create a workspace" task description are not styled correctly. Some sentences are completely bold and the bold mark down is shown.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6732948_1738660877776.20250204_104134.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Production behaviour

bandicam.2025-02-04.11-31-56-320.mp4

@NJ-2020

This comment has been minimized.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Feb 4, 2025

its coming from -> #55222, confirmed with revert #56313

@NJ-2020
Copy link
Contributor

NJ-2020 commented Feb 4, 2025

Oops, Sorry

@c3024
Copy link
Contributor

c3024 commented Feb 4, 2025

@Amoralchik

Could you raise a PR?

We should avoid escaping text only for the trackExpense task and not for other tasks.

Here

                task.type === 'trackExpense' ? false : true,

@Amoralchik
Copy link
Contributor

@c3024

I disagree that this is related to my changes. But I agree it's been detected this issue after implementing them.

The main problem is handling shouldEscapeText in unescapeText in expensify-common.

As we can see, the description starts with the <strong> tag, which causes the strange "Invite your team*" and only closes this tag after "*Invite member" in list item 4.This happens due to incorrect text processing, and as I noticed during testing, it is related to the presence of ">" in the text.

I also need to fix other issues, so anyway I can add this to avoid shouldEscapeText for this text.

@izarutskaya
Copy link

izarutskaya commented Feb 5, 2025

Issue is not reproducible

Recording.2839.mp4
Recording.2975.mp4

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Feb 6, 2025
@nkuoch nkuoch closed this as completed Feb 10, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants