[Due for payment 2025-02-13] Track expense - App is stuck on the confirmation page when submitting expense to someone

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.expensify.com
2. Go to Expenses.
3. Create an unreported expense (report is set to none).
4. Log in to staging.new.expensify.com with the same account.
5. Go to self DM.
6. Click on the expense created on Old Dot.
7. Click on the report header.
8. Click Submit it to someone.
9. Select any user or workspace.
10. On confirmation page, click Create button.

Expected Result:

The expense will be submitted to the destination without issue.

Actual Result:

App is stuck on the confirmation page when submitting expense to someone.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6732945_1738660816353.20250204_084504.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production behaviour

bandicam.2025-02-04.11-33-48-150.mp4

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App is stuck on the confirmation page when submitting expense to someone.

What is the root cause of that problem?

It comes from #55341. When the expense is created in OldDot actionableWhisperReportActionID is undefined then it's stuck here.

App/src/libs/actions/IOU.ts

Lines 4428 to 4430 in 582a892

	if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) {
	return;
	}

What changes do you think we should make in order to solve the problem?

Remove !actionableWhisperReportActionID condition here

App/src/libs/actions/IOU.ts

Lines 4428 to 4430 in 582a892

	if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) {
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[techievivek]

Seems like a regression and was already pointed out by the reviewer here https://expensify.slack.com/archives/C01GTK53T8Q/p1738663295636299?thread_ts=1738661984.529329&cid=C01GTK53T8Q, @nkdengineer @allgandalf do you mind taking a look and fixing this up? Thanks.

[nkdengineer]

Will raise a fix in the morning.

[nkdengineer]

@allgandalf we have a follow up PR here

[techievivek]

We are moving with CPing the changes to staging https://expensify.slack.com/archives/C07J32337/p1738758170054779

[izarutskaya]

Issue was fixed for the latest build

bandicam.2025-02-05.19-45-08-768.1.mp4

Recording.378.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging]fix: App is stuck on the confirmation page when submitting expense #56397

If no regressions arise, payment will be issued on 2025-02-13. 🎊

[melvin-bot]

@techievivek @NicMendonca @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]