Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable #56067

Open
1 of 8 tasks
m-natarajan opened this issue Jan 30, 2025 · 6 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 30, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation (hyperlinked to channel name): travel

Action Performed:

  1. Navigate to a hotel booking details
  2. Click on View trip details

Expected Result:

The cancellation policy may be listed as one of the following: UNKNOWN, NON-REFUNDABLE, FREE CANCELLATION UNTIL a specified date, or PARTIALLY REFUNDABLE.

Actual Result:

Cancellation policy is being shown as NON_REFUNDABLE instead of plain text Non Refundable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @blazejkustra
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan
Copy link
Author

m-natarajan commented Jan 30, 2025

@blazejkustra Tagging you as per this comment

@blazejkustra
Copy link
Contributor

Thanks @m-natarajan, commenting for assigment!

@blazejkustra
Copy link
Contributor

You need to make a reservation that is not refundable, then you'd see NON_REFUNDABLE in the details page.

PR with a fix is up, and I was able to reproduce this bug.

@OfstadC
Copy link
Contributor

OfstadC commented Jan 30, 2025

Thanks @blazejkustra !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Reviewing Has a PR in review Weekly KSv2
Development

No branches or pull requests

6 participants