Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Reports - Card details page opens in the background when opening and closing filter page #55707

Open
2 of 8 tasks
IuliiaHerets opened this issue Jan 24, 2025 · 9 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Search

Action Performed:

Precondition:

  • User has assigned themselves a virtual card.
  1. Launch ND or hybrid app.
  2. Go to workspace settings > Expensify Card.
  3. Tap on the card.
  4. Tap View transactions.
  5. Tap Filter button.
  6. Close filter page by swiping to the right.

Expected Result:

When filter page opens and closes, it will not show card details page in the background.

Actual Result:

When filter page opens and closes, it shows card details page in the background.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6722459_1737699027568.ScreenRecording_01-24-2025_14-09-20_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @parasharrajat
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Jan 24, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 24, 2025

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 24, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 24, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 24, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@techievivek techievivek removed the DeployBlockerCash This issue or pull request should block deployment label Jan 24, 2025
@techievivek
Copy link
Contributor

Removing the blocker label since it's a minor bug with navigation stack, users should be able to use the app without any issue.

@allgandalf
Copy link
Contributor

please drop this to daily

@techievivek techievivek added Daily KSv2 and removed Hourly KSv2 labels Jan 27, 2025
@parasharrajat
Copy link
Member

Will be looking into this today.

@parasharrajat
Copy link
Member

So we have dismissed the card details modaldismissModal before opening the search page but when we go back, it will not take us to the card details page but instead to the central page(card list page).

Does this behaviour look good? @allgandalf

@allgandalf
Copy link
Contributor

So we have dismissed the card details modaldismissModal before opening the search page but when we go back, it will not take us to the card details page but instead to the central page(card list page).

Does this behaviour look good? @allgandalf

BINGOOOO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants