Invoices - Bank account pop-up shows "undefined" instead of the bank currency

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, repro on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Workspace Settings

Action Performed:

Precondition:

• User has added a bank account (US or any country) in Invoices page.

1. Launch ND or hybrid app.
2. Go to workspace settings > Invoices.
3. Tap on the bank account row.

Expected Result:

The pop-up will show the bank currency.

Actual Result:

The pop-up shows "undefined" instead of the bank currency.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6722183_1737667199659.ScreenRecording_01-24-2025_05-16-37_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 01:29:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The pop-up shows "undefined" instead of the bank currency.

What is the root cause of that problem?

We do not pass the account currency to generate description here:

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Line 112 in fb0de61

description: PaymentUtils.getPaymentMethodDescription(accountType, account),

causing it to be undefined:

App/src/libs/PaymentUtils.ts

Lines 32 to 34 in b386ff5

	if (accountType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT && 'accountNumber' in account) {
	return `${bankCurrency} ${CONST.DOT_SEPARATOR} ${translateLocal('paymentMethodList.accountLastFour')} ${account.accountNumber?.slice(-4)}`;
	}

What changes do you think we should make in order to solve the problem?

Pass account?.additionalData?.currency as bankCurrency:

App/src/libs/PaymentUtils.ts

Lines 32 to 34 in b386ff5

	if (accountType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT && 'accountNumber' in account) {
	return `${bankCurrency} ${CONST.DOT_SEPARATOR} ${translateLocal('paymentMethodList.accountLastFour')} ${account.accountNumber?.slice(-4)}`;
	}

We should check other places using getPaymentMethodDescription to see if there're similar issues and pass currency accordingly.

1 simple improvement is we can only show the account currency if it exists:

App/src/libs/PaymentUtils.ts

Lines 32 to 34 in b386ff5

	if (accountType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT && 'accountNumber' in account) {
	return `${bankCurrency} ${CONST.DOT_SEPARATOR} ${translateLocal('paymentMethodList.accountLastFour')} ${account.accountNumber?.slice(-4)}`;
	}

`${bankCurrency? `${bankCurrency} ${CONST.DOT_SEPARATOR} ` : ''}${translateLocal('paymentMethodList.accountLastFour')} ${account.accountNumber?.slice(-4)}`

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

@MonilBhavsar @shubham1206agra @DylanDylann is this NAB b/c of the same beta as #55672 (comment)?

[shubham1206agra]

@Beamanator This is a BE bug. Can you mark this internal?

[MonilBhavsar]

Feature is under beta, so not a blocker. I'll take a look

[melvin-bot]

@abekkala, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MonilBhavsar]

Working on this today

[MonilBhavsar]

@shubham1206agra this looks client side bug

[melvin-bot]

@abekkala, @MonilBhavsar, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

@shubham1206agra As mentioned here, I think we can combine @mkzie2 's idea in the PR It will help us prevent similar bugs in other cases