Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Errors] Console Error Cleanup part trois... or tre... or.... #55045

Open
mallenexpensify opened this issue Jan 10, 2025 · 11 comments
Open
Assignees
Labels
Reviewing Has a PR in review Task Weekly KSv2

Comments

@mallenexpensify
Copy link
Contributor

@kubabutkiewicz can you add the issues in a post below? please use - [ ] for the list so you can check 'em off once they're done. Thx

@kubabutkiewicz
Copy link
Contributor

Hello, Im Jakub from Callstack and would like to help with this issue

@kubabutkiewicz
Copy link
Contributor

kubabutkiewicz commented Jan 10, 2025

  • Native - Attachment view `None of the callback in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callback as 'worklet' to run them on the UI thread.
  • MoneyRequestConfirmationListFooter - Each child in a list should have a unique 'key' prop
  • TextBlock - Each child in a list should have a unique 'key' prop
  • Web - validateDOMNesting(...): <button> cannot appear as a descendant of <button>.
  • SearchRouter - Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
  • URL - Error parsing URL: TypeError: Failed to construct 'URL': Invalid URL

@kubabutkiewicz
Copy link
Contributor

I already started to work on that and have already fixed

  • Native - Attachment view `None of the callback in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callback as 'worklet' to run them on the UI thread.

  • MoneyRequestConfirmationListFooter - Each child in a list should have a unique 'key' prop

  • TextBlock - Each child in a list should have a unique 'key' prop

those three issues. Today I will start working on that Web - validateDOMNesting(...): cannot appear as a descendant of .

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Jan 16, 2025
@kubabutkiewicz
Copy link
Contributor

Hi, I created a PR fixing all those console errors, also during development I found 2 more so I decided also to apply fixes to those. I will add them to list above

@kubabutkiewicz
Copy link
Contributor

Update:
got a review from a C+ on my PR, I will need to resolve some comments

@kubabutkiewicz
Copy link
Contributor

Update:
PR is still under review

@kubabutkiewicz
Copy link
Contributor

Update:
PR is still under review

@cead22
Copy link
Contributor

cead22 commented Jan 30, 2025

@kubabutkiewicz it looks like we have a few more errors and warnings, see https://expensify.slack.com/archives/C01GTK53T8Q/p1738245635535469.

Can you tackle these as part of this issue or would you prefer we make a new one? Thanks!

@kubabutkiewicz
Copy link
Contributor

Hi @cead22 I cant open link to slack unfortunately but I think you mean this thread right https://callstack-hq.slack.com/archives/C01GTK53T8Q/p1738245635535469 (if you can open it 😅) ? If yes yeah sure I can tackle them in current PR.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 31, 2025
@mallenexpensify mallenexpensify changed the title Console Error Cleanup part trois... or tre... or.... [Console Errors] Console Error Cleanup part trois... or tre... or.... Feb 3, 2025
@mallenexpensify
Copy link
Contributor Author

Yeah @kubabutkiewicz , posted in that same thread, linked back to here and tagged ya. Thx!

@kubabutkiewicz
Copy link
Contributor

Alright, I am working on adding fix for that one too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants