[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$250] Android - Group - Start Group button moves up and space is created below on confirmation tab

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.82-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Expensify app
2. Tap on the FAB and select "Start Chat"
3. Add some users to a group chat
4. With the keyboard still opened, tap on "Next"
5. Check the behaviour of "Create Group" button on confirmation tab

Expected Result:

"Create Group" button should be displayed on the bottom of the screen

Actual Result:

"Start Group" button moves up when navigating to confirmation tab when keyboard opened, and is displayed overlapping the members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6709354_1736362810159.Start_Group.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877366568381385662
• Upwork Job ID: 1877366568381385662
• Last Price Increase: 2025-01-09
• Automatic offers:
• nkdengineer | Contributor | 105627869

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[tgolen]

I see some changes to the participant selector in #53760 @JKobrynski Do you think this is related to your changes?

[tgolen]

Hm, I guess maybe not since that PR was reverted #54878

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Start Group" button moves up when navigating to confirmation tab when keyboard opened, and is displayed overlapping the members list

What is the root cause of that problem?

The keyboard is not dismissed when we go to the next page or dismissed completely after we go to the next page. Then the button moves up.

App/src/pages/NewChatPage.tsx

Line 271 in 5fb81d6

const createGroup = useCallback(() => {

For me it just moves up briefly while the keyboard is dismissing.

Screen.Recording.2025-01-09.at.16.12.41.mov

What changes do you think we should make in order to solve the problem?

Dismiss the keyboard before go the next page here

Keyboard.dismiss();

App/src/pages/NewChatPage.tsx

Line 278 in 5fb81d6

Navigation.navigate(ROUTES.NEW_CHAT_CONFIRM);

Or we can use InteractionManager.runAfterInteractions to wait for the keyboard dismiss's animation to complete before going to the next page.

App/src/pages/NewChatPage.tsx

Line 278 in 5fb81d6

Navigation.navigate(ROUTES.NEW_CHAT_CONFIRM);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result

Screen.Recording.2025-01-09.at.16.15.18.mov

[tgolen]

Thanks @nkdengineer do you have any idea why this is only happening now, and on staging? It must be related to some recent PR, right?

[nkdengineer]

@tgolen I think it's related to upgrade RN PR.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tgolen]

Ah, OK. Well, your proposal looks good and is nice and simple so I think we should move forward with that fix.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877366568381385662

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[nkdengineer]

@tgolen Is this ready for the PR phase or we're waiting for C+ review phase?

[s77rt]

@nkdengineer Thanks for the proposal. This kind of bug should be fixed globally and it appears that we already have a solution in place (shouldDismissKeyboardBeforeClose in <ScreenWrapper />). Can you check why this is not working as expected?

App/src/components/ScreenWrapper.tsx

Lines 209 to 219 in df73b07

	// We need to have this prop to remove keyboard before going away from the screen, to avoid previous screen look weird for a brief moment,
	// also we need to have generic control in future - to prevent closing keyboard for some rare cases in which beforeRemove has limitations
	// described here https://reactnavigation.org/docs/preventing-going-back/#limitations
	const beforeRemoveSubscription = shouldDismissKeyboardBeforeClose
	? navigation.addListener('beforeRemove', () => {
	if (!Keyboard.isVisible()) {
	return;
	}
	Keyboard.dismiss();
	})
	: undefined;

[nkdengineer]

@s77rt I checked and the listener isn't triggered. The reason can be the new chat page isn't removed then this listener doesn't trigger.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@s77rt The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix the start group button moves up #55020

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @trjExpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix the start group button moves up #55020

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @trjExpensify @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Upstream (RN upgrade)

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Upgrade to React Native 0.76 #51475 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: n/a

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  Bug requires regression test: No

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[trjExpensify]

Agree we don't need a new unique regression test for this issue, as it was caught as a deploy blocker during testing of the group creation flows.

Payment summary as follows:

• $250 to @s77rt for the C+ review (Go ahead and request!)
• $250 to @nkdengineer for the PR (paid!)

Closing, thanks everyone!

[JmillsExpensify]

$250 approved for @s77rt