[HOLD for payment 2025-02-04] [$125] iOS - Extra spacing before field label

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.82-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Money Requests

Action Performed:

1. Launch ND or hybrid app.
2. Go to workspace chat.
3. Create an expense with merchant and description.
4. Go to transaction thread.
5. Tap Description or Manual or Date.
6. Note that there is spacing before field label.
7. Go to workspace settings > Workspace profile.
8. Tap Workspace name.
9. Note that there is spacing before field label.

Expected Result:

There should be no spacing before field label.

Actual Result:

There is spacing before field label.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6709222_1736352878571.ScreenRecording_01-09-2025_00-13-56_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877309187559460244
• Upwork Job ID: 1877309187559460244
• Last Price Increase: 2025-01-09
• Automatic offers:
• shubham1206agra | Contributor | 105665977

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[jliexpensify]

This looks like a UI issue, not an actual deploy blocker. Will defer to Puneet though.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877309187559460244

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[mountiny]

I agree this seems like an issue that we should not block on but definitely need to fix it

Gonna make it $125

If you can identify the offending PR (and its not the RN upgrade 😅) you will get $50 and the authors will fix this

[melvin-bot]

Upwork job price has been updated to $125

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Extra spacing before field label

What is the root cause of that problem?

The issue occurs because the Input label uses an animation scale, which scales to the center instead of aligning to the left. This causes extra spacing when the input has a value. That worked as expected before upgrading rn 0.76.5, I’m not sure why upgrading to 0.76.5 caused this issue.

What changes do you think we should make in order to solve the problem?

We can replace the scale to fontSize.
from

App/src/components/TextInput/TextInputLabel/index.native.tsx

Line 9 in 5fb81d6

const animatedStyle = useAnimatedStyle(() => styles.textInputLabelTransformation(labelTranslateY, labelScale));

to

    const animatedStyle = useAnimatedStyle(() => {
        return {
            transform: [{ translateY: labelTranslateY.get() }],
            fontSize: interpolate(labelScale.value, [0, styleConst.INACTIVE_LABEL_SCALE], [0, variables.fontSizeNormal])
        }
    });

POC

Before	After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-09.at.15.11.36.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-09.at.15.10.41.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No, UI bug

What alternative solutions did you explore? (Optional)

N/A

[shubham1206agra]

@blazejkustra @sumo-slonik This looks related to Reanimated. Can you please look into this?

[blazejkustra]

Sure, we'll have a look tomorrow

edit: looking now

[blazejkustra]

I reverted the code from this PR and the same thing happens when using react-native's Animated. Meaning the migration wasn't the cause.

[jliexpensify]

Done @shubham1206agra - is this part of an existing project?

[shubham1206agra]

This should be part of RN upgrade. Otherwise, we are handling Reanimated changes in animation migration

[jliexpensify]

Cool, ty! Will assign this to #quality based on the 2nd link

[blazejkustra]

Update: I'll start working on it tomorrow morning.

[blazejkustra]

Sorry for delay, I experienced iOS issues yesterday and got distracted by other tasks in the process 🙇 Here is a PR ready!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix extra spacing before field label #55346

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@shubham1206agra @jliexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jliexpensify]

@shubham1206agra I'm guessing there's no need for a checklist here?

Payment Summary

• C: @blazejkustra (agency)
• C+: @shubham1206agra $125 - please accept the offer

[shubham1206agra]

@jliexpensify Offer accepted

[jliexpensify]

@shubham1206agra any checklist needed here?

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Upgrade to React Native 0.76 #51475 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

No Test is required here as this was a deploy blocker

Do we agree 👍 or 👎

[jliexpensify]

Thanks! Paid and job closed.