Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per diem - The string "Qty" in the Confirm details page is not translated into Spanish #54902

Closed
3 of 8 tasks
vincdargento opened this issue Jan 7, 2025 · 8 comments
Closed
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@vincdargento
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found while executing QA for PR #54252

Version Number: 9.0.81-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54252
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Precondition
Workspace has Per diem enabled and Per diem rates loaded.
The selected language in Preferences is Spanish.

Steps:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Create expense > Per diem tab
  3. Select any country
  4. Select start and end dates
  5. Select any Subrate
  6. Enter any Quantity
  7. Click on Save

Expected Result:

The string "Qty" in the Confirm details page is translated into Spanish.

Target string: Qty
Suggested string: Cant

Actual Result:

The string "Qty" in the Confirm details page is not translated into Spanish.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

Bug6708448_1736276751132!Qty_not_translated

View all open jobs on GitHub

@vincdargento vincdargento added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 7, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 7, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 7, 2025
@thienlnam
Copy link
Contributor

Behind beta so not a blocker - cc @shubham1206agra looks like an easy one to add into your PR

@shubham1206agra
Copy link
Contributor

Will be fixed in https://github.com/Expensify/App/pull/54760/commits/6aa760e40347c306df3b1da99e9bb5abf1537132

@VictoriaExpensify
Copy link
Contributor

Closing this out since it will be fixed in the above mentioned GH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants