Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Per diem - Error persists after entering value in empty fields #54831

Closed
8 tasks
lanitochka17 opened this issue Jan 6, 2025 · 17 comments
Closed
8 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 6, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.81-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Workspace has per diem rates
    1.Go to staging.new.expensify.com
    2.Go to workspace chat
  1. Click + > Submit expense > Per diem
  2. Enter valid time > Next
  3. On subrate page, click Next without entering anything
  4. Enter value in all the required fields

Expected Result:

Error will disappear after entering value in empty fields

Actual Result:

Error persists after entering value in empty fields

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6707513_1736191239412.20250107_030230__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021886843772305414689
  • Upwork Job ID: 1886843772305414689
  • Last Price Increase: 2025-02-04
Issue OwnerCurrent Issue Owner: @thesahindia
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 6, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented Jan 6, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@shubham1206agra
Copy link
Contributor

Will be fixed in c3688b4

@thienlnam
Copy link
Contributor

Per diem is behind beta so not a blocker

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 7, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 15, 2025

@stitesExpensify Still overdue 6 days?! Let's take care of this!

@stitesExpensify
Copy link
Contributor

@shubham1206agra did this end up getting fixed?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 15, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@stitesExpensify
Copy link
Contributor

Bump @shubham1206agra

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 21, 2025
Copy link

melvin-bot bot commented Jan 27, 2025

@stitesExpensify Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 29, 2025

@stitesExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jan 31, 2025

@stitesExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Feb 4, 2025

@stitesExpensify 12 days overdue. Walking. Toward. The. Light...

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Feb 4, 2025
@stitesExpensify stitesExpensify added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 4, 2025
@melvin-bot melvin-bot bot changed the title Per diem - Error persists after entering value in empty fields [$250] Per diem - Error persists after entering value in empty fields Feb 4, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021886843772305414689

Copy link

melvin-bot bot commented Feb 4, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@stitesExpensify
Copy link
Contributor

Oops sorry, I was on the wrong issue. This can be closed, it was fixed here #54760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants