[HOLD for payment 2021-11-05] Payments - Selecting "Add PayPal.me" modifies the existing PayPal.me username

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. On a user with a existing Paypal.me username set up
2. Navigate to Payments
3. Click on add payment method
4. Click on Paypal option.

Expected Result:

The modal should say something like "Modify existing Paypal.me".

Actual Result:

Add Paypal.me button navigates the user to modify existing Paypal.me username.

Workaround:

User can add an edit the Paypal.me username so I don't think a workaround is needed.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.1-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1632167181469900

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

Should we just remove the option to add a paypal.me method if there already is one?

[jasperhuangg]

@tylerkaraszewski

Yup, I think we should remove the option to add a PayPal.me if there is one, and instead allow modifying the PayPal.me username by directly clicking the thing outlined in green:

cc @isagoico

[Santhosh-Sellavel]

@jasperhuangg wont Add payment method option be weird now? Without any options?

[jasperhuangg]

Well just hide it if there are no options right?

[Santhosh-Sellavel]

Yes, correct we will just hide it.

[parasharrajat]

Watch out! I have already removed paypal from these options in #4177 (comment).

PR is under review thus this would be duplicate work. It was removed days ago even before this issue was reported.

[Santhosh-Sellavel]

Watch out! I have already removed paypal from these options in #4177 (comment).

This comment is about not allowing wallet transfer to Paypal, not removing Paypal from Add Payment Methods.

@parasharrajat I just checked out your branch. this issue is not handled in PR #4177, I verified it in look image below.

But add PayPal route is broken. I see your PR is ready for review. Please fix this before it gets merged.

add.paypal.broken.mov

cc: @jasperhuangg

[parasharrajat]

In the next comments I have asked question to either remove it or disable it. But either of those should be sufficient to cover this issue.

That PR is still in progress and I waiting to get answers and finish it.

It will only allow adding card or bank account.

[Santhosh-Sellavel]

@parasharrajat

I saw the follow up comments, remove paypal option question alone was not answered there.

So there is no clear answer regarding remove paypal option from add payment methods. Let's wait for @stitesExpensify to answer this question.

[stitesExpensify]

I think we should wait on this because otherwise we'll do some work that doesn't need to be done. We're about to merge a PR for adding a debit card which you can have unlimited of so we will never not have options in the "Add payment method" dropdown and therefore no need to hide it.

This comment is about not allowing wallet transfer to Paypal, not removing Paypal from Add Payment Methods.

@Santhosh-Sellavel is correct here. We still want paypal as an option here because you can send money from paypal, but you can't transfer money from your wallet to paypal.

I agree that the solution here is just to hide it from the dropdown when there is already a paypal.

[Santhosh-Sellavel]

Thanks @stitesExpensify for clarity. I agree with you here Let's wait for the PR to get merged.

[MelvinBot]

@tylerkaraszewski Huh... This is 4 days overdue. Who can take care of this?

[tylerkaraszewski]

Does anyone want to take this? I"m assigned as triage and would like to hand off to someone with more knowledge on the subject.

[stitesExpensify]

I'll take it

[tylerkaraszewski]

thanks!

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1447759095553306624/job-details

External - https://www.upwork.com/jobs/~01d69c9e6a77a717cd

[jliexpensify]

Invited @Santhosh-Sellavel via Upworks.

[stitesExpensify]

just to confirm: I'll make the Upworks job and invite @Santhosh-Sellavel?

Yep. Thanks!

[parasharrajat]

@jliexpensify I think you missed the exported label here.

I will be reviewing the PR and I will let you know when this is ready for final review and possibly for merge. See More

[MelvinBot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jliexpensify]

Thanks Rajat - going to remove Carlos M though, it sounds like Brandon's got this issue.

[stitesExpensify]

Still working on this

[jliexpensify]

Note to self: I believe this qualifies for a $250 bonus.

[Santhosh-Sellavel]

@stitesExpensify PR is ready for review again #5806

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.11-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add Paypal option removed if Paypal already exists #5806

If no regressions arise, payment will be issued on 2021-11-05. 🎊

[mallenexpensify]

Paid in Upwork (happened to have this open), added $250 for reporting bonus and $250 for n6-hold bonus. Thanks @Santhosh-Sellavel !

[jliexpensify]

TY @mallenexpensify - I actually jumped on to pay this today, and was wondering why it disappeared from my Assigned list haha.

[mallenexpensify]

Welcome @jliexpensify , figured it was Saturday for ya so thought I'd take care of.