[Due for payment 2025-02-10] [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Revert #52569 #54054
Comments
JmillsExpensify
added
Daily
|
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new. |
|
@JmillsExpensify The expectation is that we revert the PR, and then disable Approve button as well as Pay as a new requirement? Would it be a single PR or two PRs - one revert and then second to disable Approve? I can help with the review on this one if needed. |
|
@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
I think we want to:
|
|
@mananjadhav you're welcome to work on the PRs too if you'd like |
|
Yes, I can pick this. |
|
Great! All yours ❤️ |
|
@mananjadhav how's this one going? Do you have an ETA for the PR? |
|
I am a bit sick, I'll have the Pr by tomorrow. |
|
Ah no worries. Hope you feel better soon. |
|
@JmillsExpensify, @mananjadhav, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
Apologies I was unwell. I am just getting back and will have this ready in 1-2 days. |
|
@JmillsExpensify @mananjadhav @luacmartins this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
|
@JmillsExpensify, @mananjadhav, @luacmartins Huh... This is 4 days overdue. Who can take care of this? |
|
Will raise the PR today. |
melvin-bot
bot
added
Reviewing
melvin-bot
bot
changed the title
|
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-07. 🎊 For reference, here are some details about the assignees on this issue:
|
|
@mananjadhav / @parasharrajat @JmillsExpensify @mananjadhav / @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
changed the title
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-10. 🎊 For reference, here are some details about the assignees on this issue:
|
|
@mananjadhav / @parasharrajat @JmillsExpensify @mananjadhav / @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
|
We had to do a few back-and-forths to refactor the default string ID lint warning. Do we have a discussion somewhere on Slack about why this change was needed @mananjadhav except #56103 (comment). |
|
Ok, I found it. No worries. |
|
Do we need a Bug-zero checklist for this task? |
After giving the solution in #52569 a try, we've realized that it creates a confusing situation in the Inbox, which is:
ApprovedbuttonSo in short, our solution for
approveandpay(specifically with a report that has some held expenses and some unheld expenses) ends up breaking GBR.As a result, we're going to revert the PR from #52569. That restores GBR to the
Inboxand workspace chat. In addition, for the Search page specifically, we are going to disable theApprovebutton for this case, just like we landed on doing forPay.Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: