Forgot password - Validate Code is likely expired error not handled

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app and enter email
2. In password page tap forgot password
3. Tap the magic link and setup password changing the URL to include staging
4. Setup password and logout
5. Tap the same magic link to setup the password
6. Enter a password and hit submit

Expected Result:

Error message should be shown to the user, similar to expensify.com

Actual Result:

Magic link can be reused and after entering new password and confirm password, tapping setup password triggers new magic link. Password is not setup though

Workaround:

Unknown

The ideal solution here would be to handle the error that is thrown after submitting the form the 2nd time and show the error message above:

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.93-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5222384_Forgot_Password-1.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

@Jag96 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Jag96]

When testing on staging and production, I can change my password successfully, I sign out, and I click the link again which opens the same page. If I try submitting the form with a new password I get a console error:

It doesn't look like this case is handled, so I agree this should be fixed. On expensify.com we have the same kind of error, the error message doesn't come up until the user submits the form again so I think that part is fine.

Making external, all we should be doing here is displaying an error when we get the json result above. The error message can match what we have on expensify.com:

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

@Jag96 - just clarifying: should we be editing @isagoico's original issue to reflect your proposal to make it clearer in regards to what we want?

Essentially - replacing the "Expected Result" in the original issue with your JSON screenshot, and error message screenshot?

[Jag96]

@jliexpensify good call, updated!

[jliexpensify]

Posted:

Internal - https://www.upwork.com/ab/applicants/1435395558473867264/job-details
External - https://www.upwork.com/jobs/~017c7eb541afb745c2

[akshayasalvi]

Is this duplicate of #4737

I have a PR in progress for the linked issue and I am guessing it’s the same behavior

[Jag96]

Ah, good catch @akshayasalvi! Yes, I think we can close this one then since it's a dupe. @jliexpensify can you please close out the Upwork job?