[$250] [HOLD for payment 2024-10-17] Xero - Accounting page reloads when 2FA setup RHP opens

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.44-8
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• 2FA is not set up.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Connect next to Xero.
4. Click Enable two-factor authentication.

Expected Result:

Accounting page will not reload when 2FA setup RHP opens (production behavior).

Actual Result:

Accounting page reloads when 2FA setup RHP opens.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6623623_1727984521641.20241004_033910.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845920887092248256
• Upwork Job ID: 1845920887092248256
• Last Price Increase: 2024-10-14

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

I think it's coming from #49251.

cc @mkzie2

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[jasperhuangg]

Not the worst bug, we don't need to block deploy on this

[Nodebrute]

@jasperhuangg It is fixed in this #50226. But I can see a weird flicker.

Screen.Recording.2024-10-04.at.10.28.24.PM.mov

[Nodebrute]

@jasperhuangg It is fixed in this #50226. But I can see a weird flicker.

Screen.Recording.2024-10-04.at.10.28.24.PM.mov

cc: @bernhardoj

[c3024]

@jasperhuangg

The reload of the accounting pane does not happen anymore but the screen flickers. The screen flicker does not seem to be related to any changes made in #50226. We can update the present issue's description to fix the flicker and handle that in this issue.

[MonilBhavsar]

This seems related to #45572 🤔

[c3024]

@MonilBhavsar

I don't think it is related to that. The 2FA requirement modal is just a modal and not part of a modal navigator. So, I think we need not call dismissModal here. Removing it fixes this issue.

App/src/components/ConnectToXeroFlow/index.tsx

Line 37 in 08becfd

Navigation.dismissModal();

[MonilBhavsar]

Thanks for checking!
Since you know the fix, do you want to put up a PR?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix blinking on Accounting Centre Pane when clicking of modal asking for setting up of 2FA when connecting to Xero #50371

If no regressions arise, payment will be issued on 2024-10-17. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845920887092248256

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[CortneyOfstad]

@c3024 — I sent you a proposal in Upwork — please let me know once you accept! Also, please complete the checklist before 10/17 so there is no delay in issuing payment. Thank you!

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[CortneyOfstad]

@VictoriaExpensify I am heading OoO (10/15 to 10/23), so got this reassigned to keep it moving! Right now, we're waiting on @c3024 to accept the proposal here, and payment is due 10/17. Thanks!

[VictoriaExpensify]

Payment summary:
C+: @c3024 paid $250 via Upwork