Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plaid modal is no longer opening on Android #4959

Closed
marcaaron opened this issue Aug 31, 2021 · 17 comments
Closed

Plaid modal is no longer opening on Android #4959

marcaaron opened this issue Aug 31, 2021 · 17 comments
Assignees
Labels
Daily KSv2

Comments

@marcaaron
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Try to add a bank account via Plaid

Expected Result:

Plaid modal opens and we are able to do so (works on staging)

Actual Result:

White screen + nothing happens

Workaround:

No

Platform:

  • Android

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

@marcaaron marcaaron added the Daily KSv2 label Aug 31, 2021
@marcaaron marcaaron self-assigned this Aug 31, 2021
@marcaaron
Copy link
Contributor Author

Coming in from #4944 (comment)

@marcaaron
Copy link
Contributor Author

  1. The issue was reproduced on main locally
  2. The issue is not reproduced on the latest Play Store build
  3. Going to try to test staging locally to see if this can be reproduced there

@marcaaron
Copy link
Contributor Author

@Julesssss @luacmartins the issue is reproducible on the staging branch too. Which likely means this isn't a deploy blocker. But should be resolved so we can test this on dev.

I'll try to see what else could be causing this. It was working... and now isn't... but the code changes around this stuff have been pretty minimal so I'm guessing some kind of dependency broke this. But honestly not too sure.

@marcaaron
Copy link
Contributor Author

Ok so I updated the react-native-plaid-link-sdk package to see if that would help at all and it did. I think updating to the latest version of React Native must have broken this. I'm going to push up the version bump and test to make sure that iOS is still good as well.

@marcaaron
Copy link
Contributor Author

The only thing I'm noticing is that the Plaid modal is well... super slow to load... but it does work eventually.
Maybe we can create another issue to address that or bring it to Plaid's attention.

@marcaaron

This comment has been minimized.

@marcaaron

This comment has been minimized.

@marcaaron
Copy link
Contributor Author

Ok I think maybe it was just a caching issue. Seems to be working now on Android. Moving on to iOS testing.

@Julesssss
Copy link
Contributor

Julesssss commented Sep 1, 2021

Thanks for looking into this. Let us know when the PR comes off hold and can be tested.

@Julesssss
Copy link
Contributor

Leaving a reminder here that this PR should be retested after this is merged.

@marcaaron
Copy link
Contributor Author

Hey @Julesssss I re-tested your branch and looks good with the changes. No password field appears and able to advance further without one.

Edited_20210901_115820.mp4

@Julesssss
Copy link
Contributor

Perfect, thanks again for looking into this and for following up.

@Julesssss
Copy link
Contributor

That reminder was for myself, but I see it wasn't that clear now, I hope you didn't feel like I was asking you to do that 😬

@botify botify closed this as completed Sep 2, 2021
@botify
Copy link

botify commented Sep 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@marcaaron
Copy link
Contributor Author

That reminder was for myself, but I see it wasn't that clear now, I hope you didn't feel like I was asking you to do that 😬

Ah nah yer good ! Just trying to do ya a solid.

@botify
Copy link

botify commented Sep 3, 2021

🚀 Deployed to staging by @luacmartins in version: 1.0.92-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 4, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants