-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plaid modal is no longer opening on Android #4959
Comments
Coming in from #4944 (comment) |
|
@Julesssss @luacmartins the issue is reproducible on the I'll try to see what else could be causing this. It was working... and now isn't... but the code changes around this stuff have been pretty minimal so I'm guessing some kind of dependency broke this. But honestly not too sure. |
Ok so I updated the |
The only thing I'm noticing is that the Plaid modal is well... super slow to load... but it does work eventually. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ok I think maybe it was just a caching issue. Seems to be working now on Android. Moving on to iOS testing. |
Thanks for looking into this. Let us know when the PR comes off hold and can be tested. |
Leaving a reminder here that this PR should be retested after this is merged. |
Hey @Julesssss I re-tested your branch and looks good with the changes. No password field appears and able to advance further without one. Edited_20210901_115820.mp4 |
Perfect, thanks again for looking into this and for following up. |
That reminder was for myself, but I see it wasn't that clear now, I hope you didn't feel like I was asking you to do that 😬 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Ah nah yer good ! Just trying to do ya a solid. |
🚀 Deployed to staging by @luacmartins in version: 1.0.92-1 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Try to add a bank account via Plaid
Expected Result:
Plaid modal opens and we are able to do so (works on staging)
Actual Result:
White screen + nothing happens
Workaround:
No
Platform:
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: