[HOLD for Payment 2024-09-12][$250] Import categories - Nothing happens after dragging and dropping file into RHP

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click 3-dot menu.
4. Click Import spreadsheet.
5. Drag and drop a file into the RHP.

Expected Result:

The file can be dragged and dropped into the RHP.

Actual Result:

Nothing happens after dragging and dropping file into RHP.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592372_1725411668751.20240904_075359.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831640860340610285
• Upwork Job ID: 1831640860340610285
• Last Price Increase: 2024-09-05

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-09-04 09:42:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after dragging and dropping file into RHP.

What is the root cause of that problem?

The drop event data here does not include the file's URI, later we would early return if it's missing URI:

App/src/components/ImportSpreadsheet.tsx

Lines 78 to 80 in a637a8a

	if (!file.uri) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We need to manually create it following the below implementation:

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 549 to 553 in 562d7b4

	const data = event.dataTransfer?.files[0];
	if (data) {
	data.uri = URL.createObjectURL(data);
	displayFileInModal(data);
	}

In here, create URI for the file object:

if (file) {
    file.uri = URL.createObjectURL(file);
    readFile(file);
}

[tuseefahmed786]

Edited by proposal-police: This proposal was edited at 2024-09-04 09:42:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after dragging and dropping file into RHP.

What is the root cause of that problem?

The drop event data here does not include the file's URI, later we would early return if it's missing URI:

App/src/components/ImportSpreadsheet.tsx

Lines 78 to 80 in a637a8a

	if (!file.uri) {
	return;
	}

What changes do you think we should make in order to solve the problem?

We need to manually create it following the below implementation:

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 549 to 553 in 562d7b4

	const data = event.dataTransfer?.files[0];
	if (data) {
	data.uri = URL.createObjectURL(data);
	displayFileInModal(data);
	}

In here, create URI for the file object:

if (file) {
    file.uri = URL.createObjectURL(file);
    readFile(file);
}

I was considering another method. I see that manually creating the URI with URL.createObjectURL is a workable solution. However, I wanted to make a point about potential memory management issues.

When using URL.createObjectURL, it's important to remember that these object URLs persist in memory until explicitly overridden. To prevent a possible memory leak, we should make sure that we call URL.revokeObjectURL() when the object URL is no longer needed.

Would it be helpful to add this cleanup step to our solution to manage memory usage more efficiently? I'd love to get feedback!

[melvin-bot]

📣 @tuseefahmed786! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mountiny]

cc @filip-solecki @rushatgabhane @rlinoz coming from the import spreadsheet PR

[mountiny]

This indeed feels like a blocker for the feature, not demoting. Added @rushatgabhane as he reviewed the original PR #47827

[filip-solecki]

@mkzie2 Proposal looks good, maybe it will be better to put createObjectURL function inside readFile and use revokeObjectURL in finally as @tuseefahmed786 mentioned

[dannymcclain]

Random little piece of feedback that kinda almost feels related to this, can we update the "Drop your file here" text to use our text color instead of textSupporting color? textSupporting doesn't look very good on that green.

cc @Expensify/design

[mountiny]

@mkzie2 this is a deploy blocker, are you able to raise this PR and make it ready for review/ testing in the next couple of hours?

[mkzie2]

Sure thing!

[shawnborton]

I like that idea Danny!

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 10 days overdue. Is anyone even seeing these? Hello?

[MariaHCD]

The fix for this one was deployed to production. I believe we're just awaiting payment.

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Payment summary:

• Contributor: @mkzie2 $250
• Reviewer: @rushatgabhane $250

[garrettmknight]

$250 approved for @rushatgabhane

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

@mkzie2 are you still due payment on this issue?

[mkzie2]

@JmillsExpensify Yes, do you mind sending me an offer https://www.upwork.com/freelancers/~019f73367b03c6d784

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Offer sent!

[mkzie2]

@JmillsExpensify offer accepted, we can pay out and close 👍

[melvin-bot]

@JmillsExpensify, @MariaHCD, @rushatgabhane, @mkzie2 Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

All done!