[Due for payment 2025-02-18] [$250] Book Travel - Unable to continue setting up travel, error appears

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.26-4
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #47809
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Create a brand new account.
Green + > Book Travel
Enter a company address -> Press Save
Press Book Travel -> Accept the terms of service -> Press Continue

Expected Result:

Expensify Travel page opens

Actual Result:

Error appears and Unable to continue setting

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bandicam.2024-08-30.01-44-20-821.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503
• Upwork Job ID: 1829616128762264680
• Last Price Increase: 2024-08-30
• Automatic offers:
• shubham1206agra | Contributor | 105189846

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[IuliiaHerets]

We think that this bug might be related to #vip-travel

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

It's a backend error User is not on Travel Beta

[joekaufmanexpensify]

Can't reproduce, works totally fine for me. Seems like the issue was @IuliiaHerets account is not on the beta.

[joekaufmanexpensify]

Discussing more here

[joekaufmanexpensify]

@IuliiaHerets I got the applause.expensifail.com domain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!

[IuliiaHerets]

@joekaufmanexpensify Issue still reproducible. Build - v9.0.26-4, account - [email protected]

bandicam.2024-08-30.17-28-29-312.mp4

[joekaufmanexpensify]

@IuliiaHerets can you try again in ~30 minutes? It can sometimes take an hour+ for the beta to take effect.

[IuliiaHerets]

@joekaufmanexpensify QA team noticed that the issue can be reproduced with fresh accounts, after refreshing the page it works well. Build - v9.0.26-5, account - [email protected].

bandicam.2024-08-30.20-34-03-405.mp4

[joekaufmanexpensify]

Ah, yeah. I can reproduce it when I do this with a brand new account. And then no longer can after refreshing. That said, we should still fix this as feels reasonable that some people will try to use travel soon after creating their accounts.

2024-08-30_16-20-39.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[joekaufmanexpensify]

@Nodebrute are you thinking the issue here is that the beta isn't kicking in for a new account right away or something like that? As i experienced this issue, but my account is on the beta.

[Nodebrute]

@joekaufmanexpensify This was the backend response User is not on Travel Beta. I’ll retest it to confirm.

[Nodebrute]

@joekaufmanexpensify I’m not on the beta, so the response remains the same even after refreshing the page.

[joekaufmanexpensify]

@mananjadhav curious if you agree that this is likely a backend issue?

[shubham1206agra]

I will ready the PR by tomorrow

[joekaufmanexpensify]

TY!

[stitesExpensify]

Hey @shubham1206agra is the PR up?

[shubham1206agra]

@stitesExpensify Here #53753

[joekaufmanexpensify]

PR out on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Implement upgrade to collect when booking travel #53753

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@mananjadhav / @shubham1206agra @joekaufmanexpensify @mananjadhav / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mananjadhav]

Not overdue. This will be paid out tomorrow.

[joekaufmanexpensify]

@mananjadhav can you handle checklist as part of prepping for payment?

[mananjadhav]

@joekaufmanexpensify I think this is more of a feature request. This started as a backend bug and ended up becoming a feature request. Adding the checklist nevertheless and I think we should add a regression test for the same.

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: NA

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Have a new account with spotnanaTravel beta enabled and no workspace created.

Test:

1. Click on FAB Book Travel.
2. Click on Book travel.
3. Verify that upgrade flow has started.
4. Click on Upgrade.
5. Verify that workspace confirmation page appears.
6. Fill all the information
7. Click on Confirm.
8. Verify that upgrade confirmation screen appears.

Do we agree 👍 or 👎

[joekaufmanexpensify]

Regression test issue here. Checklist complete.

[joekaufmanexpensify]

All set to issue payment. We need to pay:

• @shubham1206agra - $250 for PR via Upwork.
• @mananjadhav - $250 for C+ via NewDot.

[joekaufmanexpensify]

@shubham1206agra your original offer expired, so I created a new upwork job and sent you an offer. Please accept it so we can pay you.

[joekaufmanexpensify]

@mananjadhav please request payment at your earliest convenience.

[mananjadhav]

I just did. Thanks.

[garrettmknight]

$250 approved for @mananjadhav