Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete GitHub Actions workflow tests #47010

Closed
AndrewGable opened this issue Aug 7, 2024 · 1 comment
Closed

Delete GitHub Actions workflow tests #47010

AndrewGable opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

Problem

We added Github Action tests in #13604, and while most of the problems presented in the original issue are true, we are not getting a ton of value out of the tests at the moment. We write lots of little workflow bugs that are not caught by the tests and have to spend a lot of time keeping them working. This tradeoff does not seem worth it anymore.

Solution

  • Delete the workflow_tests directory
  • Delete the testGithubActionsWorkflows.yml file
  • Delete the workflow-test script in package.json
@AndrewGable AndrewGable added the Daily KSv2 label Aug 7, 2024
@AndrewGable AndrewGable self-assigned this Aug 7, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 7, 2024
@roryabraham
Copy link
Contributor

PR merged. Thanks @AndrewGable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants