Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Dropdown not displaying properly on Company Step #4630

Closed
Jag96 opened this issue Aug 12, 2021 · 6 comments
Closed

State Dropdown not displaying properly on Company Step #4630

Jag96 opened this issue Aug 12, 2021 · 6 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Jag96
Copy link
Contributor

Jag96 commented Aug 12, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Coming from #4597, breaking this into its own issue. This is a regression from #3414

Action Performed:

  1. Navigate to staging.new.expensify.com/bank-account/new and fill out any values and hit continue
  2. Notice that on the next step (Company step) the values for the state dropdowns are taking up more space than they should, and don't follow the design convention that the rest of the form elements follow.

Expected Result:

Design should be consistent

Actual Result:

Design isn't consistent

Before Now
image image

Workaround:

N/A

Platform:

Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

@Jag96 Jag96 added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 12, 2021
@Jag96 Jag96 self-assigned this Aug 12, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Jag96 Jag96 added the Internal Requires API changes or must be handled by Expensify staff label Aug 12, 2021
@Jag96
Copy link
Contributor Author

Jag96 commented Aug 12, 2021

Going to fix this internally by updating the StatePicker to use the new ExpensiPicker instead of the old Picker component

@MitchExpensify
Copy link
Contributor

Thanks @Jag96 ! I assume this will also fix the dropdown mis-alignment in the Requestor step? Theres a state dropdown field there too

@Jag96
Copy link
Contributor Author

Jag96 commented Aug 12, 2021

Yes, good call I've updated that one as well

@Jag96
Copy link
Contributor Author

Jag96 commented Aug 17, 2021

PR is on staging and blocker is fixed, closing this

@Jag96 Jag96 closed this as completed Aug 17, 2021
@isagoico
Copy link

Looks good! Checking it off the deploy blocker list.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants