Xero - Export button is showing in report details page for Admin, but not for Employee

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: New feature
Found when validating PR : #44170
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Admin and employee are in the same workspace.
• Workspace is connected to Xero.

1. Go to staging.new.expensify.com
2. [Employee] Submit an expense in the workspace chat.
3. [Admin] Go to workspace chat with employee.
4. [Admin] Click on the expense preview.
5. [Admin] Pay elsewhere the report.
6. [Admin and employee] Note that there is Xero action button in the header.
7. [Admin and employee] Click on the report header.

Expected Result:

There should be consistency in showing Export button in report details page for both admin and employee.

Actual Result:

Export button is showing in report details page for Admin, but not for Employee.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6544826_1721203779570.20240717_160308.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[kosmydel]

I'm not sure, but this PR might fix it: #45577

[hungvu193]

I think it's expected that we only show export button with admin or manager.

[lakchote]

I think it's expected that we only show export button with admin or manager.

Exactly. We should only show the export button if it's an admin or manager.

cc @trjExpensify

Currently we're showing the export option for both (Admin/Manager and Member) if we're in a QBO setup which is wrong.

My PR #45577 solves that so it only shows the export to integration button if it's an Admin/Manager, just like the backend expects it.

[rlinoz]

Cool, so we can close this one as working as expected.

[trjExpensify]

Moving over to the PR for that Q. 👀