Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hold PR #44321] [Payment card / Subscription] Add GBP back to the Add Payment Card selector. #44896

Closed
trjExpensify opened this issue Jul 5, 2024 · 7 comments
Closed

[Hold PR #44321] [Payment card / Subscription] Add GBP back to the Add Payment Card selector. #44896

trjExpensify opened this issue Jul 5, 2024 · 7 comments
Assignees
@trjExpensify @blimpich @waterim
Labels
Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

Created this issue to remind us to do this when the 3DS/SCA flow is complete.

Todo: Revert this PR to bring back GBP. More context here.
@trjExpensify trjExpensify added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Task labels Jul 5, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jul 5, 2024
@blimpich
Copy link
Contributor

blimpich commented Jul 5, 2024

Should be handled by this PR but good to have an issue open to track this to make sure it all gets reverted, not just a portion of it.

@trjExpensify
Copy link
Contributor Author

Ah cool, maybe @waterim can comment here, and we can link that PR to this issue if we're going to take care of it there.

@waterim
Copy link
Contributor

waterim commented Jul 8, 2024

Hey Im Artem from Callstack and will worm on this issue!

@trjExpensify
Copy link
Contributor Author

Wiggle away, man! 😄

@blimpich
Copy link
Contributor

blimpich commented Jul 8, 2024

🪱

@melvin-bot melvin-bot bot added the Overdue label Jul 16, 2024
@trjExpensify
Copy link
Contributor Author

Still holding on the 3DS work.

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
@blimpich
Copy link
Contributor

This was completed by #44321

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trjExpensify trjExpensify

@blimpich blimpich

@waterim waterim

Labels
Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trjExpensify @blimpich @waterim