Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Skeleton loader not displayed in workspace member page #44604

Closed
3 of 6 tasks
izarutskaya opened this issue Jun 28, 2024 · 16 comments
Closed
3 of 6 tasks

Workspace - Skeleton loader not displayed in workspace member page #44604

izarutskaya opened this issue Jun 28, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #43893
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open app.
  2. Go to Account settings > workspace > member page
    Notice that Skeleton loader is not displayed in workspace member page when data is loading

Expected Result:

Skeleton loader is displayed in workspace member page when data is loading

Actual Result:

Skeleton loader is not displayed in workspace member page when data is loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6526935_1719542907215.video_2024-06-28_05-47-04.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 28, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@jliexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Difference between stg and prod

Recording.2587.mp4

@MariaHCD
Copy link
Contributor

Hmmm, so the skeleton view is implemented in #43893

But it doesn't look like the PR is deployed to staging yet?

cc: @truph01 @jjcoffee @blimpich

@truph01
Copy link
Contributor

truph01 commented Jun 28, 2024

  • I see that the PR is not deployed to staging.

@MariaHCD
Copy link
Contributor

@izarutskaya did we test the PR prematurely? 🤔

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 28, 2024

It seems to be an automation issue bcoz the changes of that PR are reflected in the staging branch code.

Screenshot 2024-06-28 at 19 09 31

@jjcoffee
Copy link
Contributor

Hmm so from my testing there is no issue on staging. The loader shows when the connection speed is throttled enough for it to show, exactly the same as on production. @izarutskaya Do you mind retesting with a throttled connection?

@blimpich
Copy link
Contributor

asked for retest here

@blimpich
Copy link
Contributor

Also I don't think this should block the deploy.

@blimpich blimpich removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@jliexpensify jliexpensify added Daily KSv2 and removed Hourly KSv2 labels Jul 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@jliexpensify
Copy link
Contributor

Hi, just moving to a Daily (I assume that's ok?)

@kbecciv
Copy link

kbecciv commented Jul 1, 2024

Issue is not reproduced on a slow network

Workspace.skeleton.mp4

@blimpich
Copy link
Contributor

blimpich commented Jul 1, 2024

Great lets close this then.

@blimpich blimpich closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants