Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [$250] [CSV] Add Selection mode to Search page #44577

Closed
rlinoz opened this issue Jun 27, 2024 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Jun 27, 2024

HOLD #44385

We should complete this section of the doc.

This will change the layout and how to enable the checkboxes in smaller screens.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015573ce7c34e042ac
  • Upwork Job ID: 1807832005022163303
  • Last Price Increase: 2024-07-01
Issue OwnerCurrent Issue Owner: @slafortune
@trjExpensify trjExpensify changed the title [HOLD] Add Selection mode to Search page [CSV] [HOLD #44385] Add Selection mode to Search page Jun 28, 2024
@trjExpensify trjExpensify added the Weekly KSv2 label Jun 28, 2024
@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 28, 2024
@trjExpensify
Copy link
Contributor

@filip-solecki can you comment here so I can assign you before I pop labels on it?

@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM an expert agency and I'd like to work on this!

@trjExpensify trjExpensify added the NewFeature Something to build that is a new item. label Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@slafortune slafortune added the External Added to denote the issue can be worked on by a contributor label Jul 1, 2024
@melvin-bot melvin-bot bot changed the title [CSV] [HOLD #44385] Add Selection mode to Search page [$250] [CSV] [HOLD #44385] Add Selection mode to Search page Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015573ce7c34e042ac

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 1, 2024
@trjExpensify
Copy link
Contributor

Removed the hold!

@trjExpensify trjExpensify changed the title [$250] [CSV] [HOLD #44385] Add Selection mode to Search page [$250] [CSV] Add Selection mode to Search page Jul 3, 2024
@filip-solecki
Copy link
Contributor

Hi! Draft PR is here - it is in our internal review so it should be ready for C+ tomorrow I guess

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 4, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 5, 2024
@trjExpensify
Copy link
Contributor

Rushat has context on this project imp, switching him in for the review now.

Copy link

melvin-bot bot commented Jul 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [$250] [CSV] Add Selection mode to Search page [HOLD for payment 2024-07-24] [$250] [CSV] Add Selection mode to Search page Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@rushatgabhane
Copy link
Member

@slafortune could you please attach payment summary 🙇

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 23, 2024
@slafortune
Copy link
Contributor

@rushatgabhane can you please complete the checklist?

Copy link

melvin-bot bot commented Jul 24, 2024

Payment Summary

Upwork Job

BugZero Checklist (@slafortune)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1807832005022163303/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@slafortune
Copy link
Contributor

New feature

@rushatgabhane Role contributor is owed $250 via NewDot
@filip-solecki role C+ is from an agency-contributor and not due payment

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 24, 2024
@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants