[HOLD for payment 2024-07-10] [$250] Chat - Report in the background loads infinitely after refreshing group confirmation page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Click Add to group next to a few users.
4. Click Next.
5. Refresh the confirmation page.
6. Dismiss the confirmation page.

Expected Result:

In Step 5, after refreshing the confirmation page, the report in the background will load.

Actual Result:

In Step 5, after refreshing the confirmation page, the report in the background shows infinite loading.
In Step 6, after dismissing the confirmation page, the link is https://staging.new.expensify.com/r

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6524928_1719389626682.20240626_160912.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[flodnv]

@luacmartins @truph01 @akinwale I see that we modified the loading skeleton in this PR - #43652 - could this DeployBlocker be related with that PR?

[flodnv]

Actually, that's wrong. I tested reverting that PR on main and the bug is still there.

I used git bisect which tells me that the first bad commit is af02cb4

Indeed, I tested reverting that PR on main and the bug is fixed.

@Kicu @mountiny @roryabraham @rayane-djouah

[mountiny]

Raised in slack

[Kicu]

@flodnv interesting, this PR basically does 3 things:

• remove shim for IE - highly unlikely to be a culprit
• remove forwardRef that was not used by any component - same thing
• rewrite ReportScreen from withOnyx to useOnyx - that one looks fishy

In favor of rolling forward instead of rolling back, I'd suggest we don't revert this PR but instead I will provide the revert just for the ReportScreenIDSetter file and we can test if that fixes it - sounds good?
Also @blazejkustra @roryabraham you might be interested to see if this turns out to be some kind of discrepancy between withOnyx and useOnyx

[flodnv]

That sounds fine as long as it makes sense along that PR, and as long as reverting those changes fix the bug (I tested reverting the full PR only, not just these specific changes)

[Kicu]

@flodnv this should fix it: #44463

here is me trying to reproduce the bug on on my PR:

rec-report-bug.mp4

[roryabraham]

looking at the logs, it appears that the ReportScreenWrapper is not re-rendering when we call navigation.setParams:

[roryabraham]

I figured out that adding only the reports back with withOnyx instead of useOnyx solves this problem, but I'm not sure why yet.

[roryabraham]

This is fixed and on prod, we just need to issue a C+ payment to @c3024 for the review

[roryabraham]

Context for the fix: https://expensify.slack.com/archives/C01GTK53T8Q/p1719519717862329?thread_ts=1719427166.028799&cid=C01GTK53T8Q

[roryabraham]

Just a standard $250 payout for the review here

[CortneyOfstad]

@c3024 — sent you an offer here. Please let me know once you accept. Thank you!

[c3024]

@CortneyOfstad accepted, thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[CortneyOfstad]

This has not deployed to production, as there is a deploy blocker. Going to adjust the title

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Stg] Replace ReportScreenIDSetter with useLastAccessedReportID #44559

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@c3024 can you please complete the checklist above so there is no delay in issuing payment?

Also, i sent you an offer in Upwork (job post here) Let me know once you accept and I'll get that paid ASAP tomorrow 👍

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: No PR can be help responsible.
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No. This could not have been identified earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal

1. Open any report
2. Press on FAB > Start Chat
3. Press on Add to group on some users
4. Press Next
5. Refresh the page.
6. Verify that the report opened in step 1 correctly loads in the background.

[c3024]

@CortneyOfstad accepted, thanks!

[CortneyOfstad]

Payment Summary

@c3024 — paid $250 via Upwork

Regression Test

Created here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.