Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric Cleanup: Fix default line height #43449

Closed
roryabraham opened this issue Jun 11, 2024 · 4 comments
Closed

Fabric Cleanup: Fix default line height #43449

roryabraham opened this issue Jun 11, 2024 · 4 comments
Assignees
@abekkala @s77rt @roryabraham
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jun 11, 2024 •
edited by melvin-bot bot
Loading

Problem

In the Fabric PR we updated the default line height to 21px to prevent emojis from being cut off.

This was not an appropriate solution to that problem, since the line height is defined by our design team in Figma, and the product is meant to reflect that.

Solution

Figure out how to change the default line height back to 20px without having emojis display as cut off.

Issue OwnerCurrent Issue Owner: @s77rt
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 11, 2024
@roryabraham roryabraham self-assigned this Jun 11, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 11, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@roryabraham roryabraham mentioned this issue Jun 11, 2024
Closed
6 tasks
@roryabraham
Copy link
Contributor Author

tagged our SWM fabric peeps to look at this one: https://expensify.slack.com/archives/C04878MDF34/p1718070169138449

@roryabraham
Copy link
Contributor Author

whoops, dupe of #43371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abekkala abekkala

@s77rt s77rt

@roryabraham roryabraham

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abekkala @s77rt @roryabraham