[$250] When editing comment, copy and paste text that has trailing \n, console error appears and send button changed to grey, can not send

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.80-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @badeggg
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1717559130850559

Action Performed:

1. Open any chat page
2. in the composer box, copy text that has trailing a trailing line break, \n, paste it to the composer box, ie.

test

Expected Result:

No error logging in console and can send text

Actual Result:

Console error appears and send button changed to grey, can not send

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

cc.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01296f154c567ad13d
• Upwork Job ID: 1802744039321176346
• Last Price Increase: 2024-06-17

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[situchan]

Here's clear repro step:

1. Copy this code block

test

2. Paste into composer

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

The issue appears to have to do with the trailing space or linebreak at the end, when it's removed, you can post. Does that sound right @badeggg and @situchan

w_e5779e27696d0562df5cc72192db49420213f1cc.mp4

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[badeggg]

The issue appears to have to do with the trailing space or linebreak at the end,

Not exactly, trailing line break can repro, trailing space can not.

when it's removed, you can post

Actually, you just need change the comment just a little bit after pasting (e.g. add letter 'a' in what ever place), you can post.

By the way, is this issue waiting proposals from external?

[badeggg]

If you are using vscode, select two lines(one line is ok too) and cmd + c to copy, like this:

If you use vim, shift + v enter visual mode, shift + " + * + y to copy, like this:

Paste to composer box, error appears

[situchan]

The issue appears to have to do with the trailing space or linebreak at the end, when it's removed, you can post. Does that sound right @badeggg and @situchan

w_e5779e27696d0562df5cc72192db49420213f1cc.mp4

The video you shared correctly explains the bug. Send button is disabled along with console error.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01296f154c567ad13d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mallenexpensify]

Opening this up for proposals, @badeggg , did you want to submit one?
I added trailing line break to the repro steps to be clear, since I wasn't sure what /n exactly meant.

[badeggg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When copy some text with trailing line break(\n) and past to composer box, console error appears and send button changed to grey, can not send

What is the root cause of that problem?

"react-native-live-markdown" code here, condition if (nextChar !== '\n') is not checking textNodes[i + 1] might be undefined and range.setStart(textNodes[i + 1] as Node, 0); is using textNodes[i + 1] assuming it is a node entity.

What changes do you think we should make in order to solve the problem?

Change this line from:

if (nextChar !== '\n') {

to

if (nextChar !== '\n' && textNodes[i + 1]) {

What alternative solutions did you explore? (Optional)

N/A

[BartoszGrajdek]

Hi, I’m Bartosz from SWM react-native-live-markdown team. We’ve recently decided that it would be best to actively participate in all of the issues related to the library we’re working on. That means reviewing proposals together with the Expensify team and supporting external contributors to ensure quality solutions that won’t introduce any additional regressions. 🙌🏻

I’m currently going through all of the issues that could require any changes to the library. Feel free to tag me if you need anything, later I’ll be diving into the issues more in-depth, but there’s quite a few of them so it can take a while for me to catch up. Oh and feel free to tag me in any live-markdown related issues in the future! 😄

[mallenexpensify]

Thanks @BartoszGrajdek , I added to the Live Markdown project, removed Help Wanted and bumped to weekly.
@badeggg , hang tight for now plz while we get a better handle on managing markdown improvements more holistically.

[BartoszGrajdek]

Thank you @mallenexpensify 🙌🏻

I've added a more in-depth update here. I'll be looking through proposals in the coming days. What @badeggg is suggesting to change is something that has already caused quite a few problems, so I'd rather test it carefully.

[melvin-bot]

@eVoloshchak @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[BartoszGrajdek]

I believe this was fixed here! Can we get it retested?

These changes are also coming into react-native-live-markdown later this week.

cc @mallenexpensify

[mallenexpensify]

Unable to reproduce on web, staging, Chrome. Closing. Thanks @BartoszGrajdek !