Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - Some copy is not removed #42653

Closed
2 of 6 tasks
lanitochka17 opened this issue May 27, 2024 · 8 comments
Closed
2 of 6 tasks

Onboarding - Some copy is not removed #42653

lanitochka17 opened this issue May 27, 2024 · 8 comments
Assignees
Labels
DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented May 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #42408

Action Performed:

  1. Sign up with a new account
  2. Select 'Manage teams'
  3. Enter Business Name > First Name
  4. Close the video modal

Expected Result:

'Let's get your company set up! , your dedicated specialist, is online now and can answer your initial questions or provide a demo.
💬 CHAT WITH YOUR SETUP SPECIALIST' should be removed

Actual Result:

'Let's get your company set up! , your dedicated specialist, is online now and can answer your initial questions or provide a demo.
💬 CHAT WITH YOUR SETUP SPECIALIST' is not removed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493080_1716826377012!Screenshot_2024-05-27_at_7 08 04_in_the_evening

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@puneetlath
Copy link
Contributor

@lanitochka17 I don't understand the expected behavior. What do you mean it should be "removed"?

@kavimuru
Copy link

@puneetlath I think it is dupe of #41451

@puneetlath
Copy link
Contributor

Okay got it! Closing this out then.

@trjExpensify
Copy link
Contributor

Hm, is this a dupe? I think it's saying that the PR for that issue didn't work properly maybe.

@NikkiWines
Copy link
Contributor

Ah yes sorry, the PR to update the rest of the copy beyond Let's get you set up 🔧 is handled by this internal PR which should be merged today You all are correct in that this isn't a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants