[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [LOW] Use static .svg for Travel terms & conditions page, not a .lottie file

[shawnborton]

Coming from this comment here:

Problem:
The image used in the Travel terms & conditions RHP modal is just a static .svg image, yet it was implemented as a .lottie file because that component only accepts .lottie files for the illustration portion

Solution::
Fix the component so that it can accept a static .svg file to use as the image.

This issue should be assigned to @WojtekBoman

Issue Owner

Current Issue Owner: @twisterdotcom

[shawnborton]

cc @twisterdotcom @bfitzexpensify

[twisterdotcom]

@WojtekBoman please comment on this issue!

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[melvin-bot]

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

[WojtekBoman]

Hi! I'm going to work on that :)

[shawnborton]

Wonderful! Here is the illustration you'd need: emptystate__travel.svg.zip

It should be sized at 190x172

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [MEDIUM][VIP-Travel] Use static .svg for Travel terms & conditions page, not a .lottie file #42625

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@WojtekBoman] Determine if we should create a regression test for this bug.
• [@WojtekBoman] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [MEDIUM][VIP-Travel] Use static .svg for Travel terms & conditions page, not a .lottie file #42625

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@WojtekBoman] Determine if we should create a regression test for this bug.
• [@WojtekBoman] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

@twisterdotcom I reviewed the associated PR. Can you please assign me the issue. I will require payment summary to request payment on newDot.

[twisterdotcom]

Payment Summary:

• @WojtekBoman does not require payment (Contractor)
• @sobitneupane paid $250 via newDot requests.

This does not require a regression test.

[JmillsExpensify]

$250 approved for @sobitneupane