[HOLD for payment 2024-04-25] Tax - Maximum tax amount is 0 error msg on updating currency for non-default tax rate

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #39562

Action Performed:

Precondition : Add tax rates for any WS apart from the default one

1. Tap on FAB button >> Request money
2. Select Manual option & enter amount
3. Select workspace with enabled taxes
4. On the confirm screen choose a different tax rate
5. Click on Tax amount option
6. Change currency to a different option & tap on Save button (Note: Error message appears)
7. Change back currency to USD & tap on save button

Expected Result:

No error message appear & tax amount get saved on changing currency for a non-default rate

Actual Result:

Maximum tax amount is 0 error msg on updating currency for non-default tax rate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6444958_1712776090538.Recording__124.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[mountiny]

@akinwale @ZhenjaHorbach can you please check as this might be coming from your PR. Thanks!

[ZhenjaHorbach]

@akinwale @ZhenjaHorbach can you please check as this might be coming from your PR. Thanks!

I'm not sure if this is related to our PR)
Since in my PR we did not change any logic
We simply deleted unnecessary routes and component that were no longer used)

But I'll try to help and find where is the problem)

[luacmartins]

I can reproduce on staging, but not locally anymore

[luacmartins]

Hmm it only happens with certain currencies

[luacmartins]

I think it might be coming from #39723

[luacmartins]

Yea, found the cause

[luacmartins]

Left a comment here - #39723 (comment)

[luacmartins]

I put up a PR, but I'm unsure if the logic makes sense. Asked the original authors for a review

[MonilBhavsar]

CP'ing here https://expensify.slack.com/archives/C07J32337/p1712828884534849

[MonilBhavsar]

Works fine!

Screen.Recording.2024-04-11.at.5.54.09.PM.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix tax amount error #40049

If no regressions arise, payment will be issued on 2024-04-25. 🎊

[luacmartins]

This was fixed internally and there was no C+ review, so we can close this.