[$250] Unbold Self DM Email in LHN when Marked Unread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.60-5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1, Click on the Search button and search for "You."
2, Enter the self DM and write a message, then mark it as unread.
3, Notice that a new message line appears, but the self-DM email in the LHN doesn't appear bold.

Expected Result:

When writing a message in self-DM and marking it as unread, the self-DM email should appear bold in LHN.

Actual Result:

When marking the message as unread in self-DM, a new message line appears above the message, but the self-DM email doesn't appear bold in LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438480_1712265005065.Screen_Recording_2024-04-04_at_2.08.10_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170aaaa13241fdd11
• Upwork Job ID: 1776255609655586816
• Last Price Increase: 2024-04-05

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0170aaaa13241fdd11

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark as unread on a self dm report won't show the LHN title as bold.

What is the root cause of that problem?

After this PR, we don't bold the title if the notification preference of the report is MUTE. In self DM case, the notification preference is MUTE, so the title isn't bold.

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 58 in 7dcb3e0

const textUnreadStyle = optionItem?.isUnread && optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];

What changes do you think we should make in order to solve the problem?

If we want to make an exception to self DM, we can ignore the notification preference if it's a self DM.

const textUnreadStyle = optionItem?.isUnread && (optionItem.isSelfDM || optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE) ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];

we can apply the fix to other places where the PR touches it

[projects-ashish]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When marking the message as unread in self-DM from RHN options, Then in the self-DM email/report doesn't appear bold in LHN. But when opened it then new Message line came before it.

What is the root cause of that problem?

• In LHN, we don't bold the email/report title if the notification preference of the report is MUTE. In thi case, "DO NOT mark muted reports unread in the LHN (eg, in bold), even if they have unread messages"
• In self DM case, the notification preference is MUTE, so the this isn't bold.
• This is caused after this Don't treat muted reports as unread in LHN #33779 and added below code to cause:

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 58 in 7dcb3e0

const textUnreadStyle = optionItem?.isUnread && optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];

What changes do you think we should make in order to solve the problem?

• As In self DM case, the notification preference is MUTE, we can not changes to preference in that case, we can do any one from below:

Proposal 1:
We should not enable the "mark as unread" feature for notifications and also remove the "new message" label from this message since he is adding the message for himself. You can check this in Slack.

Proposal 2:
If we want to make exception to bold the report in LHN in case self DM, then we can do this:

const textUnreadStyle = optionItem?.isUnread && (optionItem?.isSelfDM ?? optionItem.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE) ? [textStyle, styles.sidebarLinkTextBold] : [textStyle];
   

After Fixed Result

Screen.Recording.2024-04-06.at.1.28.38.PM.mp4

[melvin-bot]

📣 @projects-ashish! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[projects-ashish]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0145304c35e1920e71?viewMode=1&s=1110580755107926016

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[cubuspl42]

@slafortune

After this #33779, we don't bold the title if the notification preference of the report is MUTE. In self DM case, the notification preference is MUTE, so the title isn't bold.

Doesn't this make the observed behavior the expected behavior? Maybe the report is a result of an outdated regression test?

[slafortune]

Ah! Thanks @cubuspl42 , Yes - I agree!

Closing