[HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #33897

Version Number: v1.4.43-6
Reproducible in staging?: y
Reproducible in production?: n
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause-Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Create a manual request.
4. Go to request details page.
5. Click 3-dot menu > Hold request.
6. Add a reason and submit it.
7. Log out.
8. Log in.
9. Go to request details page.
10. Click Got it on the Hold request education modal.
11. Repeat Step 6-8.

Expected Result:

Hold Request education modal will not appear again after relogin.

Actual Result:

Hold Request education modal reappears after relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6386748_1708514823925.bandicam_2024-02-21_04-07-12-584.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0135c085e6de6bb2c1
• Upwork Job ID: 1760290228470611968
• Last Price Increase: 2024-02-21

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0135c085e6de6bb2c1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[rlinoz]

I don't think this is a blocker, but I am also unsure about the expected behavior here, if this should never show to the same user we may need some backend fix.

CC'ing @robertjchen as you might know the expected behavior

[robertjchen]

Yeah, definitely not a blocker. I guess we can commit this to the user's NVP to prevent future display 🤔 Let me check on the proper approach here.

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from the expert agency Software Mansion, and I'd like to work on this issue.

I implemented the hold interstitial and it already uses local NVP variables to store whether or not the modal has been shown to the user, at first glance it looks like there's a problem with properly saving and reading Onyx state. I'll investigate and come up with a fix.

[robertjchen]

thank you @cdOut !

[melvin-bot]

@cdOut Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[cdOut]

Hi, I've came across some problems during main merge, will update it and complete the PR soon.

[melvin-bot]

@cdOut Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@cdOut Still overdue 6 days?! Let's take care of this!

[robertjchen]

bump @cdOut 🙏

[melvin-bot]

@cdOut Still overdue 6 days?! Let's take care of this!

[cdOut]

I'm on it, sorry for the delays 🙇

[robertjchen]

Discussion/Clarification ongoing in PR, we're close!

[robertjchen]

Final discussion/tests 🙏

[robertjchen]

Hoping to get this wrapped up this week, we're close!

[robertjchen]

Backend fix under review and to be deployed!

[robertjchen]

The fix is now fully out and confirmed fixed on production, so closing this for now. Please comment if there are any remaining items.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Held requests] Hold Request education modal reappears after relogin #40435

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
• [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cdOut] Determine if we should create a regression test for this bug.
• [@cdOut] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: